feat: sprint1 api implementation by minto1226 · Pull Request #40 · sessatakuma/jpcorrect-backend

minto1226 · 2026-05-17T08:56:34Z

目的

完成要求的三個api功能

新使用者會被更新至資料庫中
取出使用者目前檔案
使用者能更新自己暱稱與頭像

方法／實作說明

功能1. API層的 UserInitHandler() 接到 supabaseID 以及 email 後，呼叫 usecase 層的 InitUser() 進行 Create()。
功能2. API層的 UserMeHandler() 用 userID 去搜尋並回傳
功能3. API層的 UserMeUpdateHandler() 用 userID 去搜尋，並將要更新的暱稱與頭像(inputData) 更新上去

主要修改：
- 於API層新增 UserInitHandler(), UserMeHandler(), UserMeUpdateHandler()，取代原來的三函數。
- 新增 usecase 層處理判斷邏輯，加入user.go並在其中新增 nitUser().
- 加入 GetBySupabaseID() 函數
關鍵實作：

關聯 Issue

附註

TODO：
- 進行 test

wade00754

@minto1226 你是不是沒有 rebase 好，swagger的commit完全被你刪光了

minto1226 · 2026-05-27T04:14:05Z

闖大禍了搜里
@wade00754 現在應該弄好了再麻煩你檢查一次了

wade00754

還有一些問題要釐清，另外新加的Handler麻煩都要上swagger註解及產生新檔案

wade00754 · 2026-05-29T17:40:57Z

-			users.POST("", api.UserCreateHandler)
-			users.GET("/:id", api.UserGetHandler)
-			users.PUT("/:id", api.UserUpdateHandler)


這三個endpoint都沒有要留嗎?跟下面的問題一樣

UserCreateHandler是會被UserInitHandler取代掉嗎?

UserGetHandler應該要保留的

UserUpdateHandler明明還在為什麼把路由刪了?

是，UserCreateHandler 會用 UserInitHandler 取代

我理解錯清單的要求了已經把 UserGetHandler 以及 UserUpdateHandler 加回來了

wade00754 · 2026-05-29T17:41:33Z

-func (a *API) UserGetHandler(c *gin.Context) {
-	idStr := c.Param("id")
-	id, err := uuid.Parse(idStr)
-	if err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": "invalid UUID format"})
-		return
-	}


UserGetHandler 怎麼刪掉了?應該要保留的 Ref

我漏看了，之後把它加回來

wade00754 · 2026-05-29T17:56:50Z

-	user, err := a.userRepo.GetByID(c.Request.Context(), id)
+// Returns the current user's profile
+func (a *API) UserMeHandler(c *gin.Context) {
+	supabaseID := c.GetString("userID")


根據後端 API 實現清單:

Middleware 將 backend User.id 寫入 c.Get("userID") 供 handler 使用

所以‵userID是User的id而不是supabase_user_id`，但這裡寫的應該是Supabase Auth 的 user UUID，不是 backend 資料庫的 User.id。

jpcorrect-backend/internal/api/auth.go

Line 169 in 662d66e

c.Set("userID", claims.Subject)

要請 @torrid-fish 確認一下清單是不是有誤

wade00754 · 2026-05-29T17:58:36Z

-func (a *API) UserCreateHandler(c *gin.Context) {
-	var user domain.User
-	if err := c.ShouldBindJSON(&user); err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})


UserCreateHandler是會被UserInitHandler取代掉嗎?

是，之後若確認 UserInitHandler 沒問題會將 UserCreateHandler 刪掉

wade00754 · 2026-05-29T18:00:11Z

有需要新增usecase層嗎? @G36maid

以目前來說不需要。

那init的邏輯放到哪一層比較好？

First-login 用,以 JWT 中的 supabase_user_id + email 建立 User row(若已存在則 idempotent return)。回傳完整 User profile

wade00754 · 2026-05-29T18:00:32Z


 # Dependency directories (remove the comment below to include it)
 # vendor/
+node_modules/


go應該不會有node_modules/才對?

github-actions · 2026-06-06T10:16:48Z

🛡️ PR Quality Check Summary

✅ PR Title: Passed (Length: 32/75, Format: OK). feat: sprint1 api implementation
✅ Branch Name: Follows naming convention (feat/api-implementation)
✅ Commit Messages: All 2 commit(s) passed (Length, Format, Case)
✅ Conflicts: No merge conflict markers found
✅ YAML Files: All 4 file(s) passed validation
✅ JSON Files: All 1 file(s) are valid
✅ TOML Files: No TOML files found to check
✅ Go Quality: All checks passed.

🎉 All checks passed!

minto1226 requested review from G36maid and wade00754 as code owners May 17, 2026 08:56

minto1226 closed this May 17, 2026

minto1226 changed the title ~~Feat/api implementation~~ Feat: sprint1 1.1 api implementation May 17, 2026

minto1226 reopened this May 17, 2026

minto1226 changed the title ~~Feat: sprint1 1.1 api implementation~~ Feat: api implementation May 17, 2026

minto1226 changed the title ~~Feat: api implementation~~ feat: api implementation May 17, 2026

minto1226 force-pushed the feat/api-implementation branch 3 times, most recently from 111cb4b to 9043c07 Compare May 18, 2026 04:53

wade00754 requested changes May 23, 2026

View reviewed changes

minto1226 changed the title ~~feat: api implementation~~ feat: sprint1 api implementation May 27, 2026

hotfix: return to the past commit and fix the conflict

662d66e

minto1226 force-pushed the feat/api-implementation branch from f0a9989 to 662d66e Compare May 27, 2026 04:10

wade00754 requested changes May 29, 2026

View reviewed changes

fix: rebound UserGetHandler and UserUpdateHandler

8d3123e

Conversation

minto1226 commented May 17, 2026

目的

方法／實作說明

關聯 Issue

附註

Uh oh!

wade00754 left a comment

Choose a reason for hiding this comment

Uh oh!

minto1226 commented May 27, 2026

Uh oh!

wade00754 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

minto1226 Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 6, 2026

🛡️ PR Quality Check Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

minto1226 Jun 6, 2026 •

edited

Loading