Skip to content

fix: add completed state checker#27

Merged
wade00754 merged 1 commit into
mainfrom
fix/todo-reminder
Dec 24, 2025
Merged

fix: add completed state checker#27
wade00754 merged 1 commit into
mainfrom
fix/todo-reminder

Conversation

@torrid-fish

Copy link
Copy Markdown
Member

目的

對沒有assignee的task也檢查completed_state

Copilot AI review requested due to automatic review settings December 24, 2025 14:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where shared role-based tasks without assignees were not being filtered by their completion state. The fix ensures that completed tasks are excluded from todo lists regardless of whether they have a specific assignee or are shared with a role.

  • Added completion state check for tasks without assignees (shared role-based tasks)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

🛡️ PR Quality Check Summary

PR Title: Passed (Length: 32/75, Format: OK). fix: add completed state checker
Branch Name: Follows naming convention (fix/todo-reminder)
Commit Messages: All 1 commit(s) passed (Length, Format, Case)
Conflicts: No merge conflict markers found
Python Quality: All checks passed.


🎉 All checks passed!

@wade00754 wade00754 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wade00754 wade00754 added this pull request to the merge queue Dec 24, 2025
Merged via the queue into main with commit 6afb42f Dec 24, 2025
21 of 22 checks passed
@wade00754 wade00754 deleted the fix/todo-reminder branch December 24, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants