ohos: Set sign.sh to be executable in the image#141
Merged
Conversation
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
janeoa
changed the title
jschwe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, depending on the host machine, when building with the
build.shtheuv run main.pygeneratedsign.shfile does not get permission to be executable by default, and on my machine, the permissions would also make it non executable in the image. So instead of manually doing +x on thesign.shI propose adding chmod 755 to the dockerfile, so that the images gets correct permissions no matter the host settings