[#379] Fix stdout/stderr supression#380
Merged
Merged
Conversation
Problem: With PR #310, we changed some semantics regarding how stdout and stderr and handled. What we did was to get the output only after the process has exited, rather than directly piping it. This is because some commands used `spawn` rather than `output`, and we changed everything to `output`. Solution: Revert back to the old semantics. Whenever we had `status` rather than `output`, we use `status` again. I also add a new command error representing the exit status. I also noticed that some commands used `wait` rather than `wait_with_output`. I think using the latter should be innofensive, but I am unsure whether this could break something or not, so I prefer to be safe and revert to the old semantics. I noticed that we also format exit statuses by only formatting their exit codes. Well, we get nicer formatting if we format the exit status itself, so I changed it so it's prettier and more informative (now we see if we exited because of a signal).
Sereja313
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #379.
This PR restores the old semantics regarding child process handling and stdout/stderr modes. In #310, we were too eager to use
outputon processes rather thanspawnwhere needed, causing the stdout/stderr to appear "hanged" rather than directly printed.See the commit messages for more details.