fix: cancel wait process on activation failure#373
Open
paulbertin wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372
Description
This adds a target-side signal channel between
activateandwait. On the failure path,activatewrites adeploy-rs-cancel-<hash>sentinel file intemp_path. Thewaitprocess's existing inotify watcher recognizes the sentinel alongside the success canary and returnsDangerZoneError::Cancelledimmediately, instead of blocking untilactivation_timeoutelapses.Testing
Adds an integration test (
activation-failure-cancellation) that deploys an intentionally-failing profile and assertsdeployreturns within 90s, well under the 240s timeout default.Verified locally: the same test fails on
master(asserts past the threshold, onceactivation_timeoutis reached) and passes on this branch (deployment is cancelled immediately, no more👀 ❌ [wait] [ERROR] Error waiting for activation: Timeout elapsed for confirmation).