Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

[AD-446] Add a way to disable confirmation in GUI#384

Open
maksbotan wants to merge 3 commits into
masterfrom
maksbotan/ad446-gui-noconfirm
Open

[AD-446] Add a way to disable confirmation in GUI#384
maksbotan wants to merge 3 commits into
masterfrom
maksbotan/ad446-gui-noconfirm

Conversation

@maksbotan

@maksbotan maksbotan commented Nov 24, 2018

Copy link
Copy Markdown
Contributor

Description:
Problem: GUI uses tedious confirmation dialogs to make sure the user
understands what he is doing when removing wallet, sending transactions
or creating new wallet. However, this may be inconvenient for testing
and developing.

Solution: add runtime-configurable setting to disable confirmation
requests for those actions.

YT issue: https://issues.serokell.io/issue/AD-446

Checklist:

@maksbotan maksbotan added the WIP This PR represents work in progress and is not ready to be merged. label Nov 24, 2018
@maksbotan maksbotan requested a review from goodsoft as a code owner November 24, 2018 08:19
@maksbotan maksbotan force-pushed the maksbotan/ad446-gui-noconfirm branch 2 times, most recently from 2632f29 to 5f92672 Compare November 24, 2018 08:22

@gromakovsky gromakovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this issue wasn't specified properly. I've updated its description, now it has acceptance criteria.
I think that it should be part of dhall configuration, so that it can be set once and forever.
Ideally the settings dialog should update the value in configuration file, but we don't have a way to modify this configuration from the application itself yet. I think it's ok to have this setting in GUI, but write that it will apply only to the current session.
Also note that we need it in TUI as well. I think we don't need to be able to modify this value from TUI though.
Also I think that over GUI shouldn't diverge from zeplin, so if you change something (e. g. add something new), please notify @a-rukin about it so that he can update zeplin (and maybe suggest a better design).

@maksbotan maksbotan force-pushed the maksbotan/ad446-gui-noconfirm branch from 5f92672 to dbc8029 Compare January 26, 2019 19:30
@maksbotan

Copy link
Copy Markdown
Contributor Author

I made additions to satisfy criteria in YT. This can be reviewed per-commit to simplify things, after approval I intend to squash the commits.

Probably this functionality should also be documented in GUI usage guide, however that guide does not mention settings at all at the moment, so this can be done in a separate task.

Problem: GUI uses tedious confirmation dialogs to make sure the user
understands what he is doing when removing wallet, sending transactions
or creating new wallet. However, this may be inconvenient for testing
and developing.

Solution: add runtime-configurable setting to disable confirmation
requests for those actions.
@maksbotan maksbotan force-pushed the maksbotan/ad446-gui-noconfirm branch from dbc8029 to a6553a8 Compare January 26, 2019 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

WIP This PR represents work in progress and is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants