key sizes reduced for unit tests#79
Merged
Merged
Conversation
Owner
Author
|
Tests are being completed in 26 seconds now, previous one was 417.82 seconds. This means 16x times improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets
Resolves #77
What has been done
We reduced the key sizes in unit tests. Most of the cryptosystems have 1024-bit default key size. We are now using 50-bit key size for unit tests not to consume github's resources too much. Because, I recently got flagged and my account hasn't been accesible to public for a week. Even though concrete reason wasn't shared, I suspect my recent PR consumed to much cpu and memory (check out BGN's unit tests).