Ensure start_block is finalized in IndexTask::new and add tests#736
Draft
j-berman wants to merge 1 commit into
Draft
Ensure start_block is finalized in IndexTask::new and add tests#736j-berman wants to merge 1 commit into
start_block is finalized in IndexTask::new and add tests#736j-berman wants to merge 1 commit into
Conversation
kayabaNerve
force-pushed
the
next
branch
2 times, most recently
from
b325576 to
e1673f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed after #732, exposed a generic
index_task_testsfrom the index task, and then called the test from the file defining the MoneroScannerFeed. This enabled unit testing the index task test in isolation using an already implementedScannerFeed.I'm sure the daemon impl is still not ideal (I'd like to use a new docker instance rather than expect a running daemon). But if this looks solid directionally, I'll continue writing more tests.