Make STDOUT log pattern configurable via WAVE_LOG_STDOUT_PATTERN#1055
Merged
Conversation
Include month and day in the console appender timestamp so log entries are unambiguous when read across days (e.g. in k8s pod logs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
🥳 |
gwright99
approved these changes
May 28, 2026
gwright99
left a comment
Member
There was a problem hiding this comment.
Thank you! Having the date in the logs will make it much easier to troubleshoot when I have to pull log records directly via kubectl instead of via an aggregator.
Allows per-deployment override of the Logback STDOUT pattern (e.g. to omit the date prefix when the log collector already timestamps lines). Default pattern is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
tested locally: logs: |
ramonamela
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/main/resources/logback.xmlinto aWAVE_LOG_STDOUT_PATTERNproperty, so deployments can override it via env var or system property.%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg >> wt=%X{requestId}%n); deployments whose log collector already timestamps lines can set the variable to a pattern without the leading%d{...}token to drop Wave's own date prefix.docs/configuration.mdunder a new Logging section.Test plan
14:23:01.123 [main] INFO ...WAVE_LOG_STDOUT_PATTERN='[%thread] %-5level %logger{36} - %msg >> wt=%X{requestId}%n'and confirm STDOUT lines no longer carry a date prefix${WAVE_LOG_NAME}.log) is unaffected by the override🤖 Generated with Claude Code