Repository navigation
Remove Sentry integration, keep error-monitoring entry point - #170
Merged
Merged
Conversation
Drop sentry_sdk and its init call. SENTRY_DSN becomes ERROR_MONITORING_DSN, which settings.py reads and reports on but does not wire to any service, so the guarded init block remains as the place to plug in a future backend. Co-Authored-By: Claude <noreply@anthropic.com>
lbougan
approved these changes
Oct 29, 2026
lbougan
left a comment
lbougan
left a comment
Member
There was a problem hiding this comment.
Looks good. All SENTRY_DSN references are replaced (settings, conftest, test fixture, .env.SAMPLE), the dependency is gone from pyproject, and the suite passes locally (75 passed). On the server the unit files still carry SENTRY_DSN inline; it is simply unread now, and sentry_sdk can stay in the venv until the next sync. Merging and releasing as 1.5.1.
Contributor
Author
|
@lbougan Thanks. Can you please confirm that this is deployed? |
Member
|
Yep its done @cmutel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry_sdkand thesentry_sdk.init(...)call fromsettings.py.SENTRY_DSNtoERROR_MONITORING_DSN. Settings still read it and the guarded init block stays as the entry point for a future error-monitoring service. A non-empty DSN currently logs a warning that no backend is configured..env.SAMPLE, test env fixtures, andCHANGES.md.Deploy notes
SENTRY_DSNin the production.envis no longer read and can be deleted.sentry_sdkcan be removed from the app venv on the nextuvsync.Test plan
uv run --extra testing python -m pytest: 75 passed.Co-Authored-By: Claude noreply@anthropic.com