Skip to content

[UIK-5197][side-panel] rewrite component to TS#3001

Open
slizhevskyv-semrush wants to merge 3 commits into
release/v17from
UIK-5197/rewrite-component-to-ts
Open

[UIK-5197][side-panel] rewrite component to TS#3001
slizhevskyv-semrush wants to merge 3 commits into
release/v17from
UIK-5197/rewrite-component-to-ts

Conversation

@slizhevskyv-semrush

Copy link
Copy Markdown
Contributor

Changelog

@semcore/side-panel

Fixed

  • Rewrite component to TS. Deprecate atomic types. Atomic types are part of NSSidePanel namespace.

Motivation and Context

Rewrite component to TS. Deprecated atomic types in favor namespaces. Nothing changed in how component works.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

const advancedMode =
forcedAdvancedMode ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prop is neither passed from Root nor documented in the public API. Do you think it should still be listed here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's say backward compatibility =) so, maybe it's better to add it to api and marked as deprecated

Comment thread semcore/side-panel/src/SidePanel.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants