[UIK-3428][select] added autosuggest component#2949
Open
ilyabrower wants to merge 41 commits into
Open
Conversation
… typing the new one
ilyabrower
force-pushed
the
UIK-3428/autosuggest-visible-fix
branch
from
4072385 to
1a93246
Compare
ilyabrower
changed the title
…28/autosuggest-visible-fix
…:semrush/intergalactic into UIK-3428/autosuggest-visible-fix
ilyabrower
force-pushed
the
UIK-3428/autosuggest-visible-fix
branch
from
1c3bd5b to
ac2d11b
Compare
…ensitive visual style
…:semrush/intergalactic into UIK-3428/autosuggest-visible-fix
…:semrush/intergalactic into UIK-3428/autosuggest-visible-fix
…rst-last item by arrow down-up
|
|
||
| import type { NSAutoSuggest } from './AutoSuggest.type'; | ||
| import { Highlight } from './Highlight'; | ||
| import Select from '../../index'; |
Contributor
There was a problem hiding this comment.
I would suggest to import Select from './Select' rather that index file just to prevent potential issues with cycle dependencies.
Contributor
There was a problem hiding this comment.
I am wondering why this component is a part of Select rather AutoSuggest....
| class AutoSuggestRoot extends Component< | ||
| Intergalactic.InternalTypings.InferComponentProps<NSAutoSuggest.Component>, | ||
| typeof AutoSuggestRoot.enhance, | ||
| { value: (value: string) => string }, |
Contributor
There was a problem hiding this comment.
Let's move it to NSAutoSuggest namespace if you don't mind :)
| ) | ||
| : null} | ||
| <Root | ||
| neighborLocation={neigborLocation} |
Contributor
There was a problem hiding this comment.
{neigborLocation} - here is a typo? i suppose here should be neighborLocation?
…:semrush/intergalactic into UIK-3428/autosuggest-visible-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/select
Added
AutoSuggestcomponent.Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: