Fix simulator QR Codes

[tadeubas]

What is this PR for?

The Simulator had issues when encoding data into QR codes and when reading QR codes via pyzbar. This PR fixes both problems and restores reliable QR round-trips 😄.

Removed the unnecessary qr_str_to_bytes that was trying to solve those issues.

How to test:

• Use the Simulator to display a QR code.
• Take a photo with a phone (or other camera).
• Read the QR using the Datum tool inside the Simulator.

from krux.qr import to_qr_codes, FORMAT_NONE
from krux.themes import theme, WHITE
from krux.display import display
from krux.input import Input


qr_foreground = WHITE if theme.bg_color == WHITE else None
inp = Input()

data = " woahdi oawij dowaij ,./:[]123! áéíóú àè ìò ù©ç ãẽĩ õũ?"
code_generator = to_qr_codes(data, 999999999, FORMAT_NONE)
code, num_parts = next(code_generator)

# Draw QR code
if qr_foreground:
    display.draw_qr_code(
        code, light_color=qr_foreground
    )
else:
    display.draw_qr_code(code)

Changes made to:

• Code
• Tests
• Docs
• CHANGELOG

Did you build the code and tested on device?

• Yes, build and tested on

What is the purpose of this pull request?

• Bug fix
• New feature
• Docs update
• Other

[qlrd]

LGTM, just a nit

[qlrd]

need a format and lint here

[odudex]

Why does it need a custom pyzbar module?

[tadeubas]

I stumbled on the issue with the official pyzbar repo’s when reading a QRCode using SeedQReader. It had some issues with accents! Switching to the SeedSigner pyzbar fork fixed it right away. That’s when I realized the Krux simulator was also using the same buggy official pyzbar version.

I also noticed the simulator’s QR encoder was using pyqrcode, which hasn’t been updated since 2016 (yikes 😅). It turns out that library was causing encoding issues with accents too! I swapped it out for qrcode (yes, same name as MaixPy) and everything worked flawlessly.

We could use the SeedSigner release, but it pins the same buggy pyzbar version. That means developers would need to purge the existing installation to ensure the updated version is actually used. To address this, I created a bumped version in my repository.

[qlrd]

I think this make sense. IMO we could use your fork as workaround just for development branch, temporarily; a merge on your pyzbar as PR on upstream repo would be a great contribution to community and when merged (🙏🏽), we could back to original setup on develop, with both baked rabbits.

[odudex]

Please try to use the official pyzbar repo, if there's a bug, submit a PR.
If non of these work, let me know and I'll create a selfcustody fork.

Please try to fix CI errors too.

[tadeubas]

Please try to use the official pyzbar repo, if there's a bug, submit a PR. If non of these work, let me know and I'll create a selfcustody fork.

Please try to fix CI errors too.

Lol, the PR exists on "official" pyzbar for +5 years and counting...

[qlrd]

Yup, isnt a well maintained repo. Even the last commit is from 5 years ago. Isn't possible to formatting while resolve this major one?