Add tamper input mode with QR/manual options#811
Conversation
|
The Tamper Check (TC) Code is not intended to defend against attackers or protect confidential data. Its purpose is to make firmware tampering obvious and to prevent casual bypass by normal users, not to provide strong access control. The device is intentionally open to modification and scrutiny. This PR does not reduce attack friction. It only reduces user friction when entering an already user-known value. QR input also enables the use of high-entropy TC Codes that may be impractical to type or memorize. This allows users to choose longer, more complex strings without worrying about typing errors, while preserving the same security assumptions and behavior. I have no objections to this PR; the comments above are only meant to ensure that the author and reviewers share a clear understanding of what is involved. If the ability to choose between manual input and QR input is being considered as an OPSEC, I already have a related PR #485 that |
Thanks for the clarification — fully aligned. This PR intentionally avoids framing TC input as a security or OPSEC feature. No changes were made to validation logic, threat model, or startup behavior, and QR input remains strictly optional. |
What is this PR for?
This PR introduces a configurable input method for the Tamper Check Code (TC), allowing the user to:
The main goal is to reduce friction and typing errors, especially on devices without touch input or with limited navigation, while fully preserving the existing security model and default behavior.
Manual entry remains the default and is always available.
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?
Additional context / rationale
Scope and impact