Skip to content

Add Sei Solo Functions#255

Merged
codebycarson merged 6 commits into
mainfrom
precompiles/solo
Jun 10, 2025
Merged

Add Sei Solo Functions#255
codebycarson merged 6 commits into
mainfrom
precompiles/solo

Conversation

@codebycarson

@codebycarson codebycarson commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

This PR adds the Sei Solo EVM precompiles as well as the Cosmos claim and claimSpecific proto encoders.

Additional Changes:

  • Removes CT stuff
  • Biome formats the Cosmos library correctly (lots of formatting changes unfortunately)

@changeset-bot

changeset-bot Bot commented Jun 10, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6cb9dad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sei-js/cosmos Patch
@sei-js/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codebycarson codebycarson marked this pull request as ready for review June 10, 2025 15:54
@codebycarson codebycarson requested review from besated and Copilot June 10, 2025 15:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Sei Solo EVM precompiles along with Cosmos proto encoders for claim and claimSpecific, while also removing confidential transfers (CT) related modules and applying Biome formatting to the Cosmos library.

  • Updated export statements (using single quotes) in several index.ts files for consistency.
  • Removed confidential transfers code and related amino converters.
  • Updated the changeset with a new release note for the EVM migration.

Reviewed Changes

Copilot reviewed 390 out of 390 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/cosmos/library/encoding/cosmos/base/store/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/base/snapshots/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/base/reflection/v2alpha1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/base/reflection/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/base/query/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/base/kv/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/base/abci/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/bank/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/authz/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/auth/v1beta1/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/accesscontrol_x/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/cosmos/accesscontrol/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/confio/index.ts Changed export syntax formatting
packages/cosmos/library/encoding/amino.ts Removed CT-related amino converter imports
.changeset/moody-ends-tap.md Updated changeset for new solo functions and EVM migration

Comment thread .changeset/moody-ends-tap.md Outdated
break;
}

message.enforce_naming_style = reader.int32() as any;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: curious if the as any typecasting can be avoided?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a limitation of the proto generator. If CW wasn't being deprecated we could fix, but I'm making a PR literally as soon as this is merged to deprecate then delete this directory from the main branch

* type "bytes" in the open source release -- sorry, we'll try to include
* other types in a future version!
* type "bytes" in the open source release.
* TODO: make ctype actually deprecated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit confusing to understand the information here comparing L587 to this line

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the proto comments changing, as this is just generated from those, this would be an issue there, but same as the comment above, not worth optimizing as it's going away.

@codecov-commenter

codecov-commenter commented Jun 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.24422% with 213 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.49%. Comparing base (e1eb84a) to head (615676f).
⚠️ Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
packages/cosmos/library/encoding/evm/tx.ts 2.46% 158 Missing ⚠️
...mos/library/encoding/google/protobuf/descriptor.ts 5.26% 36 Missing ⚠️
packages/cosmos/library/encoding/evm/enums.ts 13.63% 19 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #255      +/-   ##
========================================
+ Coverage   7.20%   7.49%   +0.29%     
========================================
  Files        284     279       -5     
  Lines      49508   46735    -2773     
  Branches   17244   16140    -1104     
========================================
- Hits        3567    3505      -62     
+ Misses     45941   43230    -2711     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebycarson codebycarson merged commit 475b27c into main Jun 10, 2025
3 checks passed
codebycarson added a commit that referenced this pull request Jun 24, 2025
* Generate Cosmos code and add ethers/viem precompiles

* Updated Solo proto file & ran biome format on all files

* Update install-state.gz

* Added changeset

* Fixed changeset typo
codebycarson added a commit that referenced this pull request Jun 30, 2025
* Generate Cosmos code and add ethers/viem precompiles

* Updated Solo proto file & ran biome format on all files

* Update install-state.gz

* Added changeset

* Fixed changeset typo
codebycarson added a commit that referenced this pull request Jul 1, 2025
* Generate Cosmos code and add ethers/viem precompiles

* Updated Solo proto file & ran biome format on all files

* Update install-state.gz

* Added changeset

* Fixed changeset typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants