Repository navigation
Conversation
Since Linux v6.11, the syscalls of the architectures using the generic
syscall table are generated from a syscall.tbl file, and the syscall
ABIs (i.e. syscall.tbl tags) enabled for each architecture are listed
in its arch/<arch>/kernel/Makefile.syscalls file.
arch-syscall-validate had these ABIs hardcoded, and it missed the
memfd_secret ABI added for loongarch64 by kernel commit abca6583a2aa
("LoongArch: Wire up memfd_secret system call"), so memfd_secret is
missing from the loongarch64 syscall table.
Read the ABIs from Makefile.syscalls for aarch64, loongarch64, and
riscv64. This only changes the loongarch64 output, which now includes
memfd_secret.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The memfd_secret syscall was wired up for loongarch64 in Linux v7.0, but arch-syscall-validate missed it (fixed by the previous commit). This table was updated by running: $ ./arch-syscall-validate -c syscalls.csv <kernel_directory> with the same kernel version as before (v7.1-rc4), so the only change (besides the date) is the addition of memfd_secret to loongarch64. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memfd_secretwas wired up for loongarch64 in Linux v7.0 (kernel commit abca6583a2aa, "LoongArch: Wire up memfd_secret system call"), by addingsyscall_abis_64 += memfd_secretto arch/loongarch/kernel/Makefile.syscalls.arch-syscall-validatehas the syscall ABIs hardcoded for each architecture using the generic syscall table, so it missed this, andmemfd_secretis missing from the loongarch64 syscall table.This PR:
arch-syscall-validateread the ABIs fromMakefile.syscallsfor aarch64, loongarch64 and riscv64, rather than hardcoding them, so this does not happen again;syscalls.csv, using the same kernel version as before (v7.1-rc4), so the only change (besides the date) is the addition ofmemfd_secretto loongarch64.I checked that the kernel syscall dump (
arch-syscall-validate -s -a <arch>) is unchanged for aarch64 and riscv64 with Linux v6.10 (the pre-Makefile.syscallscode path), v6.11, v7.1-rc4 and v7.2, and that for loongarch64 the only addition ismemfd_secret,447(v7.1-rc4 and v7.2).I found this while comparing
syscalls.csvwith the syscalls-table data in #502. The two PRs touch the samesyscalls.csvline, so whichever is merged second needs a trivial rebase. After that, the loongarch64 kernel version formemfd_secretcan be filled in witharch-update-syscalls-csv.py(it should be v7.0).