Skip to content

BUG: seccomp_notify_fd() fails with -EBADF when file descriptor 0 is free #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfffffff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: seccomp_notify_fd() fails with -EBADF when file descriptor 0 is free #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/system.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ void sys_reset_state(void)
{
state.nr_seccomp = -1;

if (state.notify_fd > 0)
if (state.notify_fd >= 0)
close(state.notify_fd);
state.notify_fd = -1;

Expand Down Expand Up @@ -421,18 +421,14 @@ int sys_filter_load(struct db_filter_col *col, bool rawrc)
flgs |= SECCOMP_FILTER_FLAG_SPEC_ALLOW;
rc = syscall(state.nr_seccomp,
SECCOMP_SET_MODE_FILTER, flgs, prgm);
if (tsync_notify && rc > 0) {
if (listener_req && rc >= 0) {
/* return 0 on NEW_LISTENER success, but save the fd */
state.notify_fd = rc;
rc = 0;
} else if (rc > 0 && col->attr.tsync_enable) {
/* always return -ESRCH if we fail to sync threads */
errno = ESRCH;
rc = -errno;
} else if (rc > 0 && state.sup_user_notif > 0) {
/* return 0 on NEW_LISTENER success, but save the fd */
state.notify_fd = rc;
rc = 0;
}
} else
rc = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, prgm);
Expand Down
Loading