Correct bugs in variable names usage#2
Open
lavirott wants to merge 5 commits into
Open
Conversation
Replace isc-dhcp-server config by the dhcpcd default one
sebastianzillessen
left a comment
sebastianzillessen
left a comment
Owner
There was a problem hiding this comment.
Hi @lavirott thanks so much for your effort. A lot changed in the install.sh script.
Could you explain the individual comments a little bit more? Its hard for me to verify the changes right now as I don't have a raspberry Pi up and running.
Maybe you can explain the changes you did a little bit further.
Update corresponding to script modification Correct one sudo issue
Redirect script error messages to standard error Suppress the sentence in French for the same one in English (and add comment)
Author
|
This new pull request should correct all the issues you pointed out. Do not hesitate to ask me if you have any other question about the new code. |
Owner
|
Great thanks. I will try to get hold of a R-Pi in the next couple of weeks and then I will test your changes there. Thanks for contributing back! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.