Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports correct timeout forwarding and compatibility with existing callers, with no blocking issues identified; tests were not executed.
No open issues 🎉
What changed in this PR
This PR gives queued API requests more time to complete by raising the default read timeout to 30 seconds while retaining a 10-second connect timeout.
Changes:
- Adds a configurable
timeoutoption toClientand forwards it toHttpClient. - Tests default timeouts and custom tuple/scalar values for GET and POST requests.
- Documents timeout configuration and retry behavior.
| File | Description |
|---|---|
| tests/testTimeout.py | Adds tests for default and custom timeout forwarding. |
| seatsio/httpClient.py | Sets the default connect/read timeout to (10, 30). |
| seatsio/client.py | Exposes and forwards the optional timeout parameter. |
| README.md | Documents timeout defaults, configuration, and retry behavior. |
Review effort: Balanced
mroloux
deleted the
matti/seats-1825-seatsio-python-raise-default-timeout-to-30s-10s-connect
branch
October 26, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/seatsio/issue/SEATS-1825
Issue: The default 10s timeout is too short when requests wait in Cloud Run's queue during traffic spikes.
Fix: The default read timeout is now 30s, with a separate 10s connect timeout. It can be configured via the new
timeoutoption onClient.