Repository navigation
Expose table type - #280
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The additive model changes follow existing patterns and are adequately covered by focused tests.
Review effort: Balanced
Findings: None
What changed in this PR
Exposes the API’s tableType field across chart reports and event object information.
Changes:
- Added
tableTypeto chart and event object records. - Added constants for supported table types.
- Added assertions covering tables and non-table objects.
| File | Description |
|---|---|
src/main/java/seatsio/events/TableType.java |
Defines table-type constants. |
src/main/java/seatsio/events/EventObjectInfo.java |
Exposes event object tableType. |
src/main/java/seatsio/charts/ChartObjectInfo.java |
Exposes chart report tableType. |
src/test/java/seatsio/events/RetrieveEventObjectInfoTest.java |
Tests retrieved event objects. |
src/test/java/seatsio/reports/events/EventReportsTest.java |
Tests event report values. |
src/test/java/seatsio/reports/charts/AbstractChartReportsTest.java |
Tests chart report values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mroloux
marked this pull request as ready for review
September 30, 2026 08:24
mroloux
requested review from
bverbeken and
schaloner
and removed request for
a team
September 30, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose tableType on chart and event reports