Repository navigation
Run against NA server to reduce end to end latency - #279
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The endpoint and credential changes are consistently propagated through the tests and reusable workflows without identified issues.
Pull request overview
Separates general integration tests from usage-reporting tests so the main suite runs against the NA staging server while usage reports continue using EU data.
Changes:
- Updates API URL and system secret configuration for NA staging.
- Adds dedicated usage-reporting URL and secret environment variables.
- Removes usage-report tests’ dependency on the shared test-company setup.
File summaries
| File | Description |
|---|---|
src/test/java/seatsio/SeatsioClientTest.java |
Uses the general API secret configuration. |
src/test/java/seatsio/reports/usage/UsageReportTest.java |
Configures usage-report tests independently against the EU server. |
.github/workflows/tests.yml |
Adds NA and usage-reporting endpoint/secret inputs. |
.github/workflows/build.yml |
Maps repository secrets to the reusable test workflow. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mroloux
marked this pull request as ready for review
September 18, 2026 15:14
mroloux
requested review from
bverbeken and
schaloner
and removed request for
a team
September 18, 2026 15:14
schaloner
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run smoke tests against staging NA for improved performance (1m30 vs 2m30).
Note: usage reporting smoke tests still run against EU, since we're asserting usage for demo@seats.io specifically.