Repository navigation
Tests use more parallel executors - #278
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The JUnit executor configuration is unsupported and must be corrected.
Pull request overview
Updates JUnit test parallelism to 16 workers and enables Gradle dependency caching in CI.
Changes:
- Configures parallel test execution.
- Adds Gradle caching to GitHub Actions.
File summaries
| File | Summary |
|---|---|
src/test/resources/junit-platform.properties |
Configures parallel execution, but WORKER_THREAD_POOL is unsupported; use WORK_STEALING_POOL or FIXED_THREAD_POOL. |
.github/workflows/tests.yml |
Enables Gradle dependency caching. |
Review details
Suppressed comments (1)
src/test/resources/junit-platform.properties:4
WORKER_THREAD_POOLis not a supported executor-service value in JUnit Jupiter; the supported worker-pool option isWORK_STEALING_POOL(or useFIXED_THREAD_POOLfor the fixed strategy). As written, this setting is rejected/ignored by the JUnit configuration, so the requested executor change does not take effect and may fail test discovery depending on the JUnit version.
junit.jupiter.execution.parallel.config.executor-service=WORKER_THREAD_POOL
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mroloux
marked this pull request as ready for review
September 18, 2026 11:22
mroloux
requested review from
bverbeken and
schaloner
and removed request for
a team
September 18, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use 8 threads to speed up the build: