feat(core): add error taxonomy and OpenAI message interop#213
Merged
Conversation
added 2 commits
June 17, 2026 01:52
Make provider="local" usable as a first-class agent backend against self-hosted OpenAI-compatible servers: - Inline image and audio inputs through Chat Completions content parts (uploads=True) and inline text files; reject unsupported MIME types with specific guidance instead of blanket "text-only" errors. - Allow Config.model to be omitted for single-model local servers; the model field is left out of local payloads. Cloud providers still require model, and cache()/defer() raise clearly when it is missing. - Add Config.request_timeout_s (default 300s) for providers that own their transport, plumbed through to LocalProvider. Docs: document optional model and request_timeout_s in configuration.md.
Two agent-loop ergonomics improvements that build on the local provider: Error taxonomy: - ContextOverflowError (APIError subclass) classifies context-window rejections and best-effort extracts requested/allowed token counts. - ToolCallParseError classifies unparseable model tool calls. ToolCall .arguments_dict() now raises it (with tool name/id/arguments_text), and the local provider maps server-side tool-call JSON parser failures — HTTP and streamed error payloads — to the same recoverable type. OpenAI message interop: - Continuation.from_openai_messages / to_openai_messages and Message/ToolCall .from_openai / .to_openai let harnesses that already store OpenAI Chat Completions transcripts replay them through Pollux. Docs: document the OpenAI replay import/export in agent-loop.md.
4 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
seanbrar
added a commit
that referenced
this pull request
Jun 17, 2026
## Summary Make multi-turn agent loops first-class without re-creating a provider per call. - **`Session`** owns one provider instance across many `interact()` / `stream()` / `run_many()` turns and closes it on exit. The one-shot module helpers now delegate to a single-use `Session`, so their behavior is unchanged. - **Readiness probes**: a `ReadinessProvider` protocol + `ProviderReadiness` result let a provider expose a fast preflight. `Session.check_ready()` and the module-level `check_ready()` probe before packing context. The local provider implements it against `/health` and `/v1/models`, verifying the configured model when one is set. - **`local_reasoning()`** helper returns the scoped `provider_options` for local servers that honor `enable_thinking`. ## Related issue None ## Test plan `just check` passes (ruff format, ruff check, mypy, 443 tests). New tests: - `tests/interaction/test_interact_frontdoor.py`: `Session` reuses and closes its provider; module-level `check_ready()` uses the provider probe; `local_reasoning()` shape. - `tests/providers/test_local_contract.py`: local `check_ready` health-endpoint path, models fallback, missing-model reporting, model-unset skip, and model-verification requirement. ## Notes Third and final PR in the v2 RC stack. **Stacked on #213 (which is on #212)**.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two agent-loop ergonomics improvements that build on the hardened local provider (#212): a richer error taxonomy and OpenAI Chat Completions message interop.
Error taxonomy
ContextOverflowError(anAPIErrorsubclass) classifies context-window rejections and best-effort extracts requested/allowed token counts from provider messages.ToolCallParseErrorclassifies unparseable model tool calls.ToolCall.arguments_dict()now raises it (carryingtool_name/tool_call_id/arguments_text), and the local provider maps server-side tool-call JSON parser failures, both HTTP errors and streamed error payloads, to the same recoverable type.OpenAI message interop
Continuation.from_openai_messages/to_openai_messagesandMessage/ToolCall.from_openai/.to_openailet harnesses that already store OpenAI Chat Completions transcripts replay them through Pollux.Related issue
None
Test plan
just checkpasses (ruff format, ruff check, mypy, 435 tests). New tests:tests/providers/test_errors.py: context-overflow wrapping with token-count extraction.tests/interaction/test_tools.py:arguments_dict()raisesToolCallParseErrorwith metadata.tests/interaction/test_continuation.py: OpenAI message import + tool-call round-trip.tests/providers/test_local_contract.py/test_local_stream.py: local tool-call-parse classification for HTTP and SSE error payloads.Notes
Second of a 3-PR stack for v2 RC. Stacked on #212 - review/merge that first. The
Sessionruntime + readiness probes follow in the next PR.just checkpasses