Use llvm::DenseSet for seadsa_heap_abs_impl::NodeSet#102
Open
LinerSu wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <codex@openai.com>
caballa
reviewed
May 20, 2026
| std::set_union(s1.begin(), s1.end(), s2.begin(), s2.end(), | ||
| std::inserter(s3, s3.end())); | ||
| std::swap(s3, s1); | ||
| void set_difference(NodeSet &s1, const NodeSet &s2) { |
Contributor
There was a problem hiding this comment.
The original implementation of set_difference and set_union runs in O(|s1| + |s2|) because it assumes that s1 and s2 are sorted. Your implementation runs in O(|s2| x log(|s1|) which is slower for large sets. What is your motivation for changing them?
| std::set_difference(s1.begin(), s1.end(), s2.begin(), s2.end(), | ||
| std::inserter(s3, s3.end())); | ||
| std::swap(s3, s1); | ||
| OrderedNodeVec orderedNodes(const NodeSet &set) { |
Contributor
There was a problem hiding this comment.
This code is equivalent but cleaner in my opinion
OrderedNodeVec nodes(set.begin(), set.end());
std::sort(nodes.begin(), nodes.end(), NodeOrdering{});
return nodes;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seadsa_heap_abs_impl::NodeSetbacking storage fromstd::settollvm::DenseSet.orderedNodesto preserve deterministic node traversal where read/mod/new and equivalence-class results are built.DenseSetinsert and erase operations.Why
std::setis inefficient for this use case because the node collections are primarily membership sets, so the tree ordering overhead is unnecessary.llvm::DenseSetis a better fit for lookup, insertion, and deletion. Where iteration order affects observable output, nodes are sorted explicitly by SeaDsa node ID before traversal.