Repository navigation
Remember failed type creations to stop exponential generator fallback - #155
Merged
LuKrO2011 merged 1 commit intoOct 26, 2026
Merged
Conversation
Since sub-types for abstract classes are supported, _create_var_of_type tries every candidate generator until one succeeds. When no generator can build a type, e.g., an abstract class whose generators need an instance of itself, this backtracking grows exponentially with max_recursion, so the initial population for the stdlib numbers module never finished. Within the outermost _create_var_of_type call, remember the smallest depth at which creating a type failed and fail fast for the same type at that depth or deeper, before looking up its generators.
Member
|
Hi, thank you for your contribution. I have no objections merging this, but let me first fix the CI (not your fault) and check if this introduces any regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since sub-types for abstract classes are supported, _create_var_of_type tries every candidate generator until one succeeds. When no generator can build a type, e.g., an abstract class whose generators need an instance of itself, this backtracking grows exponentially with max_recursion, so the initial population for the stdlib numbers module never finished.
Within the outermost _create_var_of_type call, remember the smallest depth at which creating a type failed and fail fast for the same type at that depth or deeper, before looking up its generators.