[Fix] Release notes generator failing to fetch latest milestone#2898
Merged
Conversation
frances-h
commented
May 28, 2026
|
|
||
|
|
||
| def _get_milestone_number(client, milestone_title): | ||
| query_params = {'milestone': milestone_title, 'state': 'all', 'per_page': 100} |
Contributor
Author
There was a problem hiding this comment.
Remove 'milestone' since it's not a valid query param based on the docs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 73 73
Lines 8454 8454
=======================================
Hits 8290 8290
Misses 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frances-h
requested review from
amontanez24 and
rwedge
and removed request for
sarahmish
amontanez24
approved these changes
May 28, 2026
rwedge
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2897