Skip to content

Update in-bed-by-7.json: ScrollBarSlider#22

Open
nshutijean wants to merge 1 commit into
sdras:masterfrom
nshutijean:patch-1
Open

Update in-bed-by-7.json: ScrollBarSlider#22
nshutijean wants to merge 1 commit into
sdras:masterfrom
nshutijean:patch-1

Conversation

@nshutijean

Copy link
Copy Markdown

Reduced transparency a little:
"scrollbarSlider.activeBackground": "#191f388f",
"scrollbarSlider.background": "#191f386f",
"scrollbarSlider.hoverBackground": "#191f387f",

@rosahbruno rosahbruno left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! My only issue with the theme was trouble seeing the scroll bar.

@c5inco

c5inco commented Nov 16, 2021

Copy link
Copy Markdown

Actually, I would propose the below colors that have even more contrast and still fit well with the overall theme.

"scrollbarSlider.activeBackground": "#89A4BB48",
"scrollbarSlider.background": "#89a4bb34",
"scrollbarSlider.hoverBackground": "#89A4BB48",

I initially tried what you did (reducing the transparency), but I don't think it's enough. You can see the differences with the below screenshots across the project tree, terminal, and diff editor. It's especially noticeable when the scrollbar thumb is small (see terminal)

Project tree:

Screen Shot 2021-11-15 at 6 09 27 PM

Screen Shot 2021-11-15 at 6 09 40 PM

Diff Editor

Screen Shot 2021-11-15 at 6 10 16 PM

Screen Shot 2021-11-15 at 6 10 07 PM

Terminal

Screen Shot 2021-11-15 at 6 08 55 PM

Screen Shot 2021-11-15 at 6 08 41 PM

@nshutijean

Copy link
Copy Markdown
Author

Even better @c5inco

Actually, I would propose the below colors that have even more contrast and still fit well with the overall theme.

"scrollbarSlider.activeBackground": "#89A4BB48",
"scrollbarSlider.background": "#89a4bb34",
"scrollbarSlider.hoverBackground": "#89A4BB48",

I initially tried what you did (reducing the transparency), but I don't think it's enough. You can see the differences with the below screenshots across the project tree, terminal, and diff editor. It's especially noticeable when the scrollbar thumb is small (see terminal)

Project tree:

Screen Shot 2021-11-15 at 6 09 27 PM

Screen Shot 2021-11-15 at 6 09 40 PM

Diff Editor

Screen Shot 2021-11-15 at 6 10 16 PM

Screen Shot 2021-11-15 at 6 10 07 PM

Terminal

Screen Shot 2021-11-15 at 6 08 55 PM

Screen Shot 2021-11-15 at 6 08 41 PM

Even better 👌 I concur

@c5inco

c5inco commented Nov 22, 2021

Copy link
Copy Markdown

Now if either @sdras or another contributor could review and merge that'd be lovely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants