[FEATURE] Integrate gating & blending activations into WaveNet#193
Merged
Conversation
…ams, and _LayerArray - Removed boolean gated parameter constructors from _Layer class - Removed boolean gated parameter constructors from LayerArrayParams struct - Removed boolean gated parameter constructors from _LayerArray class - Updated all test files to use GatingMode enum instead of bool gated - Backward compatibility logic retained in Factory function for JSON parsing - All tests pass after updating to use GatingMode enum
- Added validation checks in the _Layer constructor to ensure that gating and blending activations are not provided when the gating mode is set to NONE. - Updated the constructor signature to remove default values for gating and blending activations, requiring explicit values during instantiation. - Adjusted related test cases to reflect the new constructor requirements, ensuring comprehensive coverage of the updated functionality. - Improved error handling by throwing std::invalid_argument exceptions for invalid activation configurations.
- Updated the _Layer constructor to replace gating and blending activation parameters with a single secondary_activation parameter. - Added validation to ensure secondary_activation is provided for GATED and BLENDED modes. - Adjusted related test cases to reflect the new constructor signature and ensure proper functionality. - Removed default values for gating and blending activations, enforcing explicit activation configuration during instantiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing #192 .
Changes:
Resolves #191.