Skip to content

feat: migrate to zarr v3 defaults#2439

Merged
ilan-gold merged 8 commits into
mainfrom
ig/zarr_V3_auto_shard_anndata_013
May 15, 2026
Merged

feat: migrate to zarr v3 defaults#2439
ilan-gold merged 8 commits into
mainfrom
ig/zarr_V3_auto_shard_anndata_013

Conversation

@ilan-gold

Copy link
Copy Markdown
Contributor
  • Release note not necessary because:

@ilan-gold ilan-gold added this to the 0.13.0 milestone May 12, 2026
@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.68%. Comparing base (a7ba562) to head (993e477).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2439      +/-   ##
==========================================
- Coverage   85.69%   85.68%   -0.01%     
==========================================
  Files          49       49              
  Lines        7793     7791       -2     
==========================================
- Hits         6678     6676       -2     
  Misses       1115     1115              
Files with missing lines Coverage Δ
src/anndata/_io/specs/methods.py 91.51% <100.00%> (-0.03%) ⬇️
src/anndata/_io/specs/registry.py 94.85% <ø> (ø)
src/anndata/_settings.py 92.59% <ø> (ø)

@ilan-gold
ilan-gold requested review from flying-sheep and removed request for flying-sheep May 12, 2026 18:36
@ilan-gold
ilan-gold requested a review from flying-sheep May 12, 2026 18:38
Comment thread src/anndata/_io/specs/registry.py Outdated
Comment on lines +486 to +487
>>> adata.layers["dense"] = ad.experimental.read_elem_lazy(g["layers/dense"])
>>> adata.layers["dense"]
dask.array<from-zarr, shape=(2700, 32738), dtype=float32, chunksize=(169, 2047), chunktype=numpy.ndarray>
>>> # TODO: remove ... once https://github.com/zarr-developers/zarr-python/issues/3602 becomes minimum zarr (3.1.6)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should make this not appear in the docs

Suggested change
>>> adata.layers["dense"] = ad.experimental.read_elem_lazy(g["layers/dense"])
>>> adata.layers["dense"]
dask.array<from-zarr, shape=(2700, 32738), dtype=float32, chunksize=(169, 2047), chunktype=numpy.ndarray>
>>> # TODO: remove ... once https://github.com/zarr-developers/zarr-python/issues/3602 becomes minimum zarr (3.1.6)
..
TODO: remove “...” once https://github.com/zarr-developers/zarr-python/issues/3602 becomes minimum zarr (3.1.6)
>>> adata.layers["dense"] = ad.experimental.read_elem_lazy(g["layers/dense"])

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good to know - I thought # doesn't appear in docs based on https://docs.python.org/3/library/doctest.html#how-are-docstring-examples-recognized but I guess the rendering and the output/running are different, thanks.

@ilan-gold
ilan-gold enabled auto-merge (squash) May 15, 2026 14:36
@ilan-gold
ilan-gold merged commit e5f2c7c into main May 15, 2026
24 checks passed
@ilan-gold
ilan-gold deleted the ig/zarr_V3_auto_shard_anndata_013 branch May 15, 2026 15:00
@ilan-gold ilan-gold modified the milestones: 0.13.0, 0.14.0 Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flip zarr v3 settings to turned on

2 participants