feat: migrate to zarr v3 defaults#2439
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
- Coverage 85.69% 85.68% -0.01%
==========================================
Files 49 49
Lines 7793 7791 -2
==========================================
- Hits 6678 6676 -2
Misses 1115 1115
|
ilan-gold
requested review from
flying-sheep
and removed request for
flying-sheep
May 12, 2026 18:36
Clarified the conditions for writing sharded zarr v3 stores.
flying-sheep
approved these changes
May 15, 2026
Comment on lines
+486
to
+487
| >>> adata.layers["dense"] = ad.experimental.read_elem_lazy(g["layers/dense"]) | ||
| >>> adata.layers["dense"] | ||
| dask.array<from-zarr, shape=(2700, 32738), dtype=float32, chunksize=(169, 2047), chunktype=numpy.ndarray> | ||
| >>> # TODO: remove ... once https://github.com/zarr-developers/zarr-python/issues/3602 becomes minimum zarr (3.1.6) |
Member
There was a problem hiding this comment.
this should make this not appear in the docs
Suggested change
| >>> adata.layers["dense"] = ad.experimental.read_elem_lazy(g["layers/dense"]) | |
| >>> adata.layers["dense"] | |
| dask.array<from-zarr, shape=(2700, 32738), dtype=float32, chunksize=(169, 2047), chunktype=numpy.ndarray> | |
| >>> # TODO: remove ... once https://github.com/zarr-developers/zarr-python/issues/3602 becomes minimum zarr (3.1.6) | |
| .. | |
| TODO: remove “...” once https://github.com/zarr-developers/zarr-python/issues/3602 becomes minimum zarr (3.1.6) | |
| >>> adata.layers["dense"] = ad.experimental.read_elem_lazy(g["layers/dense"]) |
Contributor
Author
There was a problem hiding this comment.
Ah, good to know - I thought # doesn't appear in docs based on https://docs.python.org/3/library/doctest.html#how-are-docstring-examples-recognized but I guess the rendering and the output/running are different, thanks.
ilan-gold
enabled auto-merge (squash)
May 15, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settingsto turned on #2239