Skip to content

chore(deps-dev): bump vue from 3.5.35 to 3.5.38#125

Merged
Goosterhof merged 2 commits into
mainfrom
dependabot/npm_and_yarn/vue-3.5.38
Jun 15, 2026
Merged

chore(deps-dev): bump vue from 3.5.35 to 3.5.38#125
Goosterhof merged 2 commits into
mainfrom
dependabot/npm_and_yarn/vue-3.5.38

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps vue from 3.5.35 to 3.5.38.

Release notes

Sourced from vue's releases.

v3.5.38

For stable releases, please refer to CHANGELOG.md for details. For pre-releases, please refer to CHANGELOG.md of the minor branch.

v3.5.37

For stable releases, please refer to CHANGELOG.md for details. For pre-releases, please refer to CHANGELOG.md of the minor branch.

Changelog

Sourced from vue's changelog.

3.5.38 (2026-06-11)

3.5.37 (2026-06-11)

3.5.36 (2026-06-11)

Bug Fixes

  • compiler-core: avoid crash on CDATA at the document root (#14916) (0ea17e2)
  • compiler-core: prefix dynamic keys on v-memo elements (#14922) (68e978e), closes #14920
  • compiler-sfc: handle vue-ignore on leading intersection/union type (#14950) (0dcd225), closes #12254
  • compiler-sfc: respect var hoisting in props destructure (48ad452)
  • reactivity: preserve watch callback return value when wrapped for once: true (#14902) (450a8a8)
  • runtime-core: add dev warning for silent catch in compat mode and fix test description typo (#14891) (db3e117)
  • runtime-core: force model update when reverted before sync (#14897) (7f76378), closes #13524
  • runtime-core: skip async component callbacks after unmount (#14911) (5300ead)
  • transition: avoid move transition for hidden v-show group children (#14895) (c11f6ee), closes #14894
  • watch: trigger immediate callback for empty sources (#14914) (1f2ca7e), closes #14898
Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 15, 2026
@dependabot dependabot Bot requested a review from a team as a code owner June 15, 2026 05:17
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 15, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying fs-packages with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8469854
Status: ✅  Deploy successful!
Preview URL: https://4258a0a2.fs-packages.pages.dev
Branch Preview URL: https://dependabot-npm-and-yarn-vue-ic6c.fs-packages.pages.dev

View logs

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/vue-3.5.38 branch 6 times, most recently from 038c810 to de3ed62 Compare June 15, 2026 10:49
@dependabot @Goosterhof
chore(deps-dev): bump vue from 3.5.35 to 3.5.38
d0ff195 
Bumps [vue](https://github.com/vuejs/core) from 3.5.35 to 3.5.38.
- [Release notes](https://github.com/vuejs/core/releases)
- [Changelog](https://github.com/vuejs/core/blob/main/CHANGELOG.md)
- [Commits](vuejs/core@v3.5.35...v3.5.38)

---
updated-dependencies:
- dependency-name: vue
  dependency-version: 3.5.38
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@Goosterhof Goosterhof force-pushed the dependabot/npm_and_yarn/vue-3.5.38 branch from de3ed62 to d0ff195 Compare June 15, 2026 12:37
@Goosterhof @claude
fix(deps): dedupe vue to a single copy via root override
8469854 
Dependabot's vue 3.5.35 -> 3.5.38 bump was partial: workspace packages
moved to 3.5.38 while the root copy stayed at 3.5.35, pinned by
@vue/server-renderer@3.5.35's exact `peer vue@"3.5.35"` (pulled in via
@vue/test-utils). vue-router resolves the root copy (3.5.35) and
packages/router resolves its own (3.5.38); vue's [RefSymbol] is a
unique symbol per copy, so the ShallowRef/Ref brands no longer match
-> TS2741/TS2345 in router.ts + the components.ts overload error.

Force a single vue across the workspace via a root `overrides` entry
(range, so future bumps still float). This re-hoists
@vue/server-renderer@3.5.38 to the root, keeping @vue/test-utils able
to resolve it. typecheck, build, lint, format, validate:dist and the
router suite (93/93) all pass with one vue copy in the tree.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Goosterhof

Goosterhof commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Pushed 8469854 to fix the failing typecheck.

Cause: this bump was partial. Workspace packages moved to vue 3.5.38, but the root copy stayed at 3.5.35, pinned by @vue/server-renderer@3.5.35's exact peer vue@"3.5.35" (pulled in transitively via @vue/test-utils). vue-router resolves the root copy (3.5.35) while packages/router resolves its own (3.5.38). Vue's [RefSymbol] is a unique symbol declared once per copy, so the ShallowRef/Ref brands across the two copies are nominally incompatible — hence TS2741/TS2345 in router.ts and the components.ts overload error.

Fix: a single root overrides entry ("vue": "^3.5.38") collapses the tree to one vue copy and re-hoists @vue/server-renderer@3.5.38 so @vue/test-utils can still resolve it. Range, not a pin, so future bumps still float. The large package-lock.json diff is almost entirely deletions — the 8 redundant nested vue toolchains the partial bump created.

Verified locally at full check-job parity: npm ci (0 vulns), format, lint, build, validate:dist, typecheck, and the router suite (93/93) all green with one vue copy in the tree.

@Goosterhof Goosterhof enabled auto-merge June 15, 2026 13:07
@Goosterhof Goosterhof added the Agent Review Requested Requesting review of specialized AI review agents. label Jun 15, 2026
Goosterhof
Goosterhof reviewed Jun 15, 2026
View reviewed changes

@Goosterhof Goosterhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approve-worthy

0 blockers · 1 concern · 0 nits · 0 praise · 1 inline

Dependabot bumps vue 3.5.35→3.5.38 (dev-dependency, all bug-fix patches). Both required checks green (check 4m15s, Cloudflare Pages pass). One scope note: the PR body says "bump vue from 3.5.35 to 3.5.38," but the diff does more than that — it raises the published peerDependencies.vue floor from ^3.5.33 to ^3.5.38 across all 8 consumer packages, and adds a new overrides.vue pin to the root package.json. Neither is a correctness problem, but the body understates the consumer-facing surface. The peerDependency floor bump is anchored inline.

Findings (detail inline)

  • package.json:46 — new overrides.vue pin + the unmentioned peerDependency floor bumps (concern).

Automated war-room agent review — posted because this PR carries the Agent Review Requested label.

Comment thread package.json
@jasperboerhof

jasperboerhof commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Loop · 9/10 · PASS

fs-packages #125 · AC anchor: none (no issue_key / plan dir / PR AC section — Dependabot dep bump) · head 8469854f10

Tip

No findings — clean against the review checklist.

Action

merge-ready

jasperboerhof
jasperboerhof approved these changes Jun 15, 2026
View reviewed changes

@jasperboerhof jasperboerhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved — review-loop verdict PASS, CI green, no human blocker, no open MAJOR+ threads. See the verdict comment + inline notes.

@Goosterhof Goosterhof merged commit 1a07d5a into main Jun 15, 2026
2 checks passed
@Goosterhof Goosterhof deleted the dependabot/npm_and_yarn/vue-3.5.38 branch June 15, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Goosterhof Goosterhof Goosterhof approved these changes

@jasperboerhof jasperboerhof jasperboerhof approved these changes

Assignees

No one assigned

Labels

Agent Review Requested Requesting review of specialized AI review agents. dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Goosterhof @jasperboerhof