refactor: inline footer sub-components into FooterWebsite#50
Conversation
✅ Deploy Preview for scri-be ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thank you for the pull request! 💙The scri.be team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local scri.be repo (can be set withgit config --global user.email "GITHUB_EMAIL")
5845ab4 to
1ebee49
Compare
|
Hi! I removed |
1ebee49 to
2319d80
Compare
2319d80 to
d00f6de
Compare
|
Giving this a quick look, @Cristiano2009Manu :) We do need yarn.lock for deployment to Netlify, so let's keep it in. There are a few more things we'll need to change, that's with the relationship between the localization files in Scribe-i18n and this repo. I'll do the fix, but to explain what I'm doing:
|
|
Did a minor change to the CSS as the medium breakpoint wasn't working properly (content was centered with text left justified). Aside from that the changes were mostly formatting :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Thanks for the great first contribution, @Cristiano2009Manu! Really appreciate the quick work and good communication here :)
Contributor checklist
Description
This PR inlines the contents of the footer sub-components
FooterFlex.vueandFooterFlexCol.vuedirectly intoFooterWebsite.vue, following the same refactor pattern as activist-org/activist#1914.Files changed:
FooterWebsite.vueto include both mobile and desktop footer layouts inlineFooterFlex.vue(sub-component no longer needed)FooterFlexCol.vue(sub-component no longer needed)footerTypes.ts(no longer needed without sub-components)Testing: Verified locally that the footer renders correctly on both mobile and desktop layouts.
Testing:
Verified locally that the footer renders correctly on both mobile and desktop layouts.
Related issue
Closes #49