Skip to content

refactor: inline footer sub-components into FooterWebsite#50

Merged
andrewtavis merged 4 commits into
scribe-org:mainfrom
Cristiano2009Manu:refactor/footer-components
Mar 13, 2026
Merged

refactor: inline footer sub-components into FooterWebsite#50
andrewtavis merged 4 commits into
scribe-org:mainfrom
Cristiano2009Manu:refactor/footer-components

Conversation

@Cristiano2009Manu

@Cristiano2009Manu Cristiano2009Manu commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Contributor checklist


Description

This PR inlines the contents of the footer sub-components FooterFlex.vue and FooterFlexCol.vue directly into FooterWebsite.vue, following the same refactor pattern as activist-org/activist#1914.

Files changed:

  • Updated FooterWebsite.vue to include both mobile and desktop footer layouts inline
  • Deleted FooterFlex.vue (sub-component no longer needed)
  • Deleted FooterFlexCol.vue (sub-component no longer needed)
  • Removed footerTypes.ts (no longer needed without sub-components)
    Testing: Verified locally that the footer renders correctly on both mobile and desktop layouts.

Testing:
Verified locally that the footer renders correctly on both mobile and desktop layouts.

Bildschirmfoto 2026-03-13 um 17 21 43 Bildschirmfoto 2026-03-13 um 17 21 23

Related issue

Closes #49

@netlify

netlify Bot commented Mar 13, 2026

Copy link
Copy Markdown

Deploy Preview for scri-be ready!

Name Link
🔨 Latest commit 7c1dd67
🔍 Latest deploy log https://app.netlify.com/projects/scri-be/deploys/69b454aa65af7e000803c593
😎 Deploy Preview https://deploy-preview-50--scri-be.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙

The scri.be team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Web rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Mar 13, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the TypeScript, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local scri.be repo (can be set with git config --global user.email "GITHUB_EMAIL")

@Cristiano2009Manu Cristiano2009Manu force-pushed the refactor/footer-components branch 2 times, most recently from 5845ab4 to 1ebee49 Compare March 13, 2026 15:18
@Cristiano2009Manu

Copy link
Copy Markdown
Contributor Author

Hi! I removed yarn.lock and package-lock.json from tracking as they shouldn't be committed. Happy to make any adjustments if needed!

@Cristiano2009Manu Cristiano2009Manu force-pushed the refactor/footer-components branch from 2319d80 to d00f6de Compare March 13, 2026 16:14
@Cristiano2009Manu Cristiano2009Manu changed the title refactor: extract shared FooterLinks type for footer components refactor: inline footer sub-components into FooterWebsite Mar 13, 2026
@andrewtavis

Copy link
Copy Markdown
Member

Giving this a quick look, @Cristiano2009Manu :) We do need yarn.lock for deployment to Netlify, so let's keep it in. There are a few more things we'll need to change, that's with the relationship between the localization files in Scribe-i18n and this repo. I'll do the fix, but to explain what I'm doing:

  • Scribe-i18n is a sub-module, so I'll send a commit over there with the changes that are needed for this project while working on it from within this project
  • I'll then pull the new version of Scribe-i18n into this project

@andrewtavis

andrewtavis commented Mar 13, 2026

Copy link
Copy Markdown
Member

Did a minor change to the CSS as the medium breakpoint wasn't working properly (content was centered with text left justified). Aside from that the changes were mostly formatting :)

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great first contribution, @Cristiano2009Manu! Really appreciate the quick work and good communication here :)

@andrewtavis andrewtavis merged commit 3802b60 into scribe-org:main Mar 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor website footer to eliminate sub-components

2 participants