Skip to content

Sparql query service approach#652

Merged
andrewtavis merged 14 commits into
scribe-org:mainfrom
harikrishnatp:sparql-query-service-approach
Nov 17, 2025
Merged

Sparql query service approach#652
andrewtavis merged 14 commits into
scribe-org:mainfrom
harikrishnatp:sparql-query-service-approach

Conversation

@harikrishnatp

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

Sparql service implementation with the universal query being https://w.wiki/FesH. and fallback query being https://w.wiki/FesZ. Also got rid of the duplicate query generation which was the main starting point of the issue.

Related issue

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙

The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Data rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@@ -1,25 +0,0 @@
#

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this file will effect on the /wikipedia/process_wiki.py

@axif0

axif0 commented Nov 15, 2025

Copy link
Copy Markdown
Member

Is it ok to skip translations data-type ? By querying translations script none of them works for now.

@harikrishnatp

Copy link
Copy Markdown
Collaborator Author

Is it ok to skip translations data-type ? By querying translations script none of them works for now.

I thought about it too, some other data types are also like that. At first i didnt query them, just the main ones we used to query. But when i ran pytest, it showed that i needed to have those data types in the file structure. Thats why I decided to query them as well.

@andrewtavis

Copy link
Copy Markdown
Member

note: We can add translations into the data types in the list file to make sure that the test passes without needing to have a query for it :)

@harikrishnatp

Copy link
Copy Markdown
Collaborator Author

data_type_metadata.json was also responsible for generation of all those data types. should be good to merge right ?

@axif0

axif0 commented Nov 15, 2025

Copy link
Copy Markdown
Member

[Note: Priority Low] Can we consider by ignoring the changes in language_data_extraction ?

As the github action runs, then it creates PR, and then we can marge the sparql files ?

@andrewtavis

Copy link
Copy Markdown
Member

I agree with @axif0 that we should just do the files for the workflow in this one. We can consider the current output files, I'll then revert their changes before merge, and then the three of us can investigate a PR from the run of the workflow 😊

@harikrishnatp

Copy link
Copy Markdown
Collaborator Author

The pre-commit hooks did its stuff but language_data_extraction is the one from the upstream. So, I'm assuming everything should be good ?

@andrewtavis

Copy link
Copy Markdown
Member

I'll take a look later tonight and bring it in, @harikrishnatp! Assuming as well that it's fine 😊

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Really amazing work here, @harikrishnatp! Really is so great that we've come to this point with Scribe-Data! Can't wait to see how the queries look once we run the workflow 😊 Thanks as well for your support in reviewing, @axif0, and thank you both of the countless calls and syncs to get here! We'll see how it works, but from here we should be good to tweak the process as needed :)

@andrewtavis

Copy link
Copy Markdown
Member

note: As mentioned above, all changes to queries are formatting from pre-commit.

@andrewtavis andrewtavis merged commit ff6b37b into scribe-org:main Nov 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants