Sparql query service approach#652
Conversation
… and rebased from upstream
Thank you for the pull request! 💙The Scribe-Data team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
…ries, regenerate sub-language queries with proper QIDs
| @@ -1,25 +0,0 @@ | |||
| # | |||
There was a problem hiding this comment.
Removing this file will effect on the /wikipedia/process_wiki.py
|
Is it ok to skip |
I thought about it too, some other data types are also like that. At first i didnt query them, just the main ones we used to query. But when i ran pytest, it showed that i needed to have those data types in the file structure. Thats why I decided to query them as well. |
|
note: We can add |
|
data_type_metadata.json was also responsible for generation of all those data types. should be good to merge right ? |
|
[Note: Priority Low] Can we consider by ignoring the changes in As the github action runs, then it creates PR, and then we can marge the sparql files ? |
|
I agree with @axif0 that we should just do the files for the workflow in this one. We can consider the current output files, I'll then revert their changes before merge, and then the three of us can investigate a PR from the run of the workflow 😊 |
|
The pre-commit hooks did its stuff but |
|
I'll take a look later tonight and bring it in, @harikrishnatp! Assuming as well that it's fine 😊 |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Really amazing work here, @harikrishnatp! Really is so great that we've come to this point with Scribe-Data! Can't wait to see how the queries look once we run the workflow 😊 Thanks as well for your support in reviewing, @axif0, and thank you both of the countless calls and syncs to get here! We'll see how it works, but from here we should be good to tweak the process as needed :)
|
note: As mentioned above, all changes to queries are formatting from pre-commit. |
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
Sparql service implementation with the universal query being https://w.wiki/FesH. and fallback query being https://w.wiki/FesZ. Also got rid of the duplicate query generation which was the main starting point of the issue.
Related issue