[essimaging] Use on-the-fly wavelength lookup table for Odin#631
Conversation
| disk_choppers = { | ||
| disk_choppers = {} | ||
| for key, ch in choppers.items(): | ||
| if ( |
There was a problem hiding this comment.
If a chopper has some empty logs, it is dropped as it is considered parked/not in use.
There was a problem hiding this comment.
Do you know how this will be handled in production? Will nexus files omit parked choppers or will they always be there? We shouldn't emit a warning if length-0 logs are a normal thing.
There was a problem hiding this comment.
My assumption is that the choppers will always be there, because they are in the template files used by ecdc.
But I asked now in the ecdc channel.
We shouldn't emit a warning if length-0 logs are a normal thing.
True. Let's see what ecdc say and then we can probably remove the warning.
There was a problem hiding this comment.
No reply from ECDC so far.
I removed the warning for now, as I am quite sure parked choppers will be in the files.
| # Run 'tox -e deps' after making changes here. This will update requirement files. | ||
| # Make sure to list one dependency per line. | ||
| dependencies = [ | ||
| "dask>=2022.1.0", |
There was a problem hiding this comment.
All these dependencies are brought in by essreduce.
Removing them here avoids the issue of always keeping all the lower bounds up to date (right now, most of the lower bounds we had were lying anyway).
There was a problem hiding this comment.
I would still list all direct dependencies here. Or at least direct 3rd party dependencies (dask, graphviz) to make sure we don't rely on essreduce's setup. We don't need to list lower bounds here as long as they are not tighter than essreduce's bounds.
Move the Odin Bragg edge workflow to build the wavelength lookup table on-the-fly from chopper parameters in the file.
For now, we patch the chopper settings on the workflow, as the info is incomplete in the template coda file that was used to create the test files.
Needs scipp/scippneutron#707