Skip to content

Fix all CI warnings (Clippy + cargo-deny)#540

Merged
primeos-work merged 2 commits into
science-computing:masterfrom
primeos-work:fix-ci-warnings
Jun 16, 2026
Merged

Fix all CI warnings (Clippy + cargo-deny)#540
primeos-work merged 2 commits into
science-computing:masterfrom
primeos-work:fix-ci-warnings

Conversation

@primeos-work

Copy link
Copy Markdown
Member
  • cb5388f: Fix Clippy warnings from the useless_borrows_in_formatting lint
  • 6c40375: Let cargo-deny ignore that the proc-macro-error2 crate is unmaintained

This isn't a security issue yet, the `aquamarine` crate should get rid
of it eventually, and this isn't really actionable for us so let's
ignore that informative advisory so that CI remains green (it's an
optional CI check but the failure could mask real vulnerabilities and
does also mark the CI run with a red cross on the GitHub UI).

https://rustsec.org/advisories/RUSTSEC-2026-0173:
> The author of proc-macro-error2 has confirmed that the crate is no
> longer maintained and recommends that users migrate away from it.
> proc-macro-error2 was originally created as a maintained fork of
> proc-macro-error (see RUSTSEC-2024-0370). Both the original crate and
> this fork are now unmaintained.

Signed-off-by: Michael Weiss <michael.weiss@bull.com>
This new lint "detects format!-style macros where an argument is passed
with an explicit & but the value is already a reference, resulting in a
double reference" [0].

[0]: https://rust-lang.github.io/rust-clippy/beta/index.html#useless_borrows_in_formatting

Signed-off-by: Michael Weiss <michael.weiss@bull.com>
@primeos-work primeos-work added this pull request to the merge queue Jun 16, 2026
Merged via the queue into science-computing:master with commit 7b2742b Jun 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant