Fix case-insensitive boolean deserialization#1619
Merged
Merged
Conversation
Contributor
Author
|
Ping @scyzoryck. This one is quick and simple. 🙏 |
Collaborator
|
Hi @NikoGrano ! Can you add an unit test to ensure that we will not miss this feature in the future, please? |
The visitBoolean() method only accepts lowercase "true"/"false" but XML APIs (notably .NET-based services) commonly return "True"/"False".
Contributor
Author
|
@scyzoryck Thanks for review. I force pushed with changes to tests and now these edge cases should be covered in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visitBoolean() method only accepts lowercase "true"/"false" but XML APIs (notably .NET-based services) commonly return "True"/"False". Apply strtolower() before comparison, consistent with how the JSON visitor already handles boolean coercion loosely via (bool) cast.