Skip to content

Add support for Symfony's DatePoint in DateHandler, close #1617#1618

Merged
scyzoryck merged 7 commits into
schmittjoh:masterfrom
Kocal:feature/datepoint-support
Mar 11, 2026
Merged

Add support for Symfony's DatePoint in DateHandler, close #1617#1618
scyzoryck merged 7 commits into
schmittjoh:masterfrom
Kocal:feature/datepoint-support

Conversation

@Kocal

@Kocal Kocal commented Feb 2, 2026

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets #1617
License MIT

@Kocal

Kocal commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

https://github.com/schmittjoh/serializer/actions/runs/21608912865/job/62381268400?pr=1618

Problem 1
- Root composer.json requires symfony/clock ^6.4 || ^7.0 || ^8.0 -> satisfiable by symfony/clock[v6.4.0, ..., v6.4.30, v7.0.0, ..., v7.4.0, v8.0.0].
- symfony/clock[v6.4.0, ..., v6.4.30] require php >=8.1 -> your php version (7.4.33) does not satisfy that requirement.
- symfony/clock[v7.0.0, ..., v7.4.0] require php >=8.2 -> your php version (7.4.33) does not satisfy that requirement.
- symfony/clock v8.0.0 requires php >=8.4 -> your php version (7.4.33) does not satisfy that requirement.

Hum, do you want me to remove symfony/clock from composer.json if PHP <8.1 in the CI, and mark tests as skipped if DatePoint is not available?

@scyzoryck

scyzoryck commented Feb 7, 2026

Copy link
Copy Markdown
Collaborator

Hum, do you want me to remove symfony/clock from composer.json if PHP <8.1 in the CI, and mark tests as skipped if DatePoint is not available?

Yes, please! Still there is about 8% of the users that are using PHP7.4 :(

@Kocal

Kocal commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

Should be better now :)

@scyzoryck

Copy link
Copy Markdown
Collaborator

@Kocal
Can you also take a look at the Static analysis action? It looks like it also needs installing package for the higher versions and ignoring errors for lower - see ignore-by-php-version.neon.php

Comment thread phpstan/ignore-by-php-version.neon.php Dismissed
Comment thread phpstan/no-datepoint.neon Dismissed
@Kocal

Kocal commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

@scyzoryck updated :)

Comment thread src/Handler/DateHandler.php Outdated
Comment thread src/Handler/DateHandler.php Outdated
@scyzoryck
scyzoryck merged commit fff5118 into schmittjoh:master Mar 11, 2026
25 of 26 checks passed
@Kocal
Kocal deleted the feature/datepoint-support branch March 11, 2026 22:44
@Kocal

Kocal commented Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for taking care of the rest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants