Enable RequireOneLinePropertyDocComment sniff#1274
Open
simPod wants to merge 1 commit into
Open
Conversation
simPod
commented
Jan 11, 2021
simPod
commented
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | |
| Fixed tickets | #... |
| License | MIT |
Collaborator
|
TBH i do not see a value in this, it was intentionally disabled that sniff (and phpstorm automatically uses the multiline version...) |
Contributor
Author
|
I thought that for easier maintenance it would be best to comply with Doctrine standard. That said removing all custom settings, exclusions etc. Eg. this sniff saves a lot of file vertical space. Phpstorm has somehow outdated file templates, that's true. In last few years phpdoc are started disappearing rapidly as we have param, return and property types. Will get event better with annotations and union types, mb even generics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.