Fix pop_select dialog crash on numpy chanlocs#231
Open
claude[bot] wants to merge 2 commits into
Open
Conversation
pop_select_dialog_spec used `EEG.get("chanlocs", []) or []`, which raises
`ValueError: The truth value of an array with more than one element is
ambiguous` on the numpy object array that eeg_checkset stores. Loading
sample_data/eeglab_data.set and opening the Select data dialog hit this
path. Route the chanlocs lookup through the shared chanlocs_as_list
helper and cover the ndarray storage with a regression test.
Fixes #229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize channel locations with the shared chanlocs_as_list helper anywhere GUI/display helpers consume EEG chanlocs, including pop_select, pop_rejcont, pop_rmbase, firfilt dialogs/filter channel-type selection, clean_rawdata artifact diagnostics, and ICLabel channel dashboards. This prevents numpy ndarray truth-value crashes after eeg_checkset and adds regression coverage for the affected user-facing paths.
Validation:
Note: uv run --no-sync ty check still reports the existing optional Torch import baseline in ICLabel/tooling in this worktree.
Fixes #229