Repository navigation
fix(import): read the csv fd before fclose - #73
Merged
Merged
Conversation
ldb_import_csv called fileno(fp) after fclose(fp) to report a close error, which is a use-after-free (gcc -Wuse-after-free). Take the fd first, as master already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ldb_import_csvreports a failedfclose(fp)withfileno(fp), called after the stream was closed. That reads a freedFILE(use-after-free); gcc flags it on every build:It only runs on the error path of
fclose, so it has not caused visible problems, but the printed fd is undefined and the access is invalid.Change
Take the fd before closing, the same pattern
masteralready uses insrc/import.c. No behavior change otherwise.Testing
src/import.ccompiles with the Makefile flags (-O -Wall ...) with no warnings.filenocall afterfcloseinsrc/.🤖 Generated with Claude Code