Chores: bump dependencies - #2542
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…lt-in xunit reporter mocha-junit-reporter is unmaintained and broken on mocha 12 due to its use of pre-class prototypal inheritance. The built-in xunit reporter produces equivalent JUnit XML and has no extra dependency. Issue: ZENKO-5364
Issue: ZENKO-5364
66e9e44 to
f8561e5
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
| @@ -111,8 +111,11 @@ def merge_reports(output_file, input_files): | |||
| all_testsuites.extend(testsuites) | |||
|
|
|||
| except ET.ParseError as e: | |||
There was a problem hiding this comment.
Not related to the pr but I just hit this bug :
4 CTST rerun, one of them I cancelled manually : End up with a file thats not parsable and it fails the whole archive step, forcing us to rerun the whole ci.
Possible further improvement that I left : Only continue on parse error when its not the latest run file
| "jest": "^30.5.2", | ||
| "js-yaml": "^5.4.2", | ||
| "sinon": "^22.1.0", | ||
| "ts-jest": "^29.4.12", |
There was a problem hiding this comment.
ts-jest@^29.4.12 is not compatible with jest@^30.5.2. ts-jest 29.x targets Jest 29 and will likely fail at runtime with Jest 30's changed transformer API. Bump to ts-jest@^30.0.0 to match the Jest major version.
| "ts-jest": "^29.4.12", | |
| "ts-jest": "^30.0.0", |
There was a problem hiding this comment.
Ok big guy, ts-jest 30 doesn't exist
| module.exports = { | ||
| reporterEnabled: 'spec, xunit', | ||
| xunitReporterOptions: { | ||
| output: process.env.MOCHA_FILE || '_reports/test-results.xml', |
There was a problem hiding this comment.
Are we ok with that ? "testsuitesTitle": "{id}" what was the goal of that ?
|
|
||
| # Ensure test results dir exists for Mocha JUnit reporter | ||
| mkdir -p "$(dirname "$MOCHA_FILE")" | ||
| # Ensure test results dir exists for Mocha xunit reporter |
There was a problem hiding this comment.
Why do we need that (mocha don't do it directly?) ? Why this change ?
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue ZENKO-5364. Goodbye sylvainsenechal. The following options are set: approve |
4 participants
ISSUE: ZENKO-5364
!! : The diff is small, mostly YARN.LCOK !
The PR is not that useful, i created it because I was starting to work on bumping Azurite, and I wanted to update libraries before. But it turns out there are enough updates to justify first creating this PR before the Azurite PR