Skip to content

chore(org): regenerate proto types with logo_url field#61

Open
srinivaskarre-sk wants to merge 2 commits into
mainfrom
b_d_org_logo
Open

chore(org): regenerate proto types with logo_url field#61
srinivaskarre-sk wants to merge 2 commits into
mainfrom
b_d_org_logo

Conversation

@srinivaskarre-sk
Copy link
Copy Markdown
Contributor

@srinivaskarre-sk srinivaskarre-sk commented May 17, 2026

Summary

  • Regenerated proto types with logoUrl field on CreateOrganization, Organization, UpdateOrganization, and auth Organization
  • No wrapper changes needed — callers pass proto types directly and can set logoUrl via CreateOrganization.newBuilder().setLogoUrl("https://...")

Test plan

  • create(CreateOrganization.newBuilder().setDisplayName("Acme").setLogoUrl("https://...").build()) returns org with logoUrl set

Summary by CodeRabbit

  • New Features
    • Added logo URL support to organization creation, update, and retrieval operations

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

Warning

Rate limit exceeded

@srinivaskarre-sk has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 47 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c003af5a-afaa-47dc-8f22-7e4a1f90123e

📥 Commits

Reviewing files that changed from the base of the PR and between 13e5f92 and 5afd7e6.

📒 Files selected for processing (1)
  • src/test/java/OrganizationTests.java

Walkthrough

This PR adds support for an optional logo_url field across protobuf Organization-related messages in both the auth and organizations packages. The field is generated with accessors, builder methods, and full serialization/deserialization integration. Incidental javadoc reference updates for deprecated fields are included.

Changes

Logo URL Field Addition

Layer / File(s) Summary
Auth Organization logo_url field
src/main/java/com/scalekit/grpc/scalekit/v1/auth/AuthProto.java, src/main/java/com/scalekit/grpc/scalekit/v1/auth/Organization.java, src/main/java/com/scalekit/grpc/scalekit/v1/auth/OrganizationOrBuilder.java
AuthProto descriptor encoding is regenerated with the new logo_url field (field 8) definition. auth/Organization message and its OrBuilder interface gain field-number constant, presence check, accessors (hasLogoUrl, getLogoUrl, getLogoUrlBytes), and builder mutators. Serialization (writeTo), size calculation, equality, and hashing logic all integrate the new field.
CreateOrganization logo_url field
src/main/java/com/scalekit/grpc/scalekit/v1/organizations/CreateOrganization.java, src/main/java/com/scalekit/grpc/scalekit/v1/organizations/CreateOrganizationOrBuilder.java
CreateOrganization message and OrBuilder add optional logo_url field (field 10) with full public API: presence constant, accessors, builder methods (setLogoUrl, clearLogoUrl, setLogoUrlBytes), and integration into message serialization, equality, hashing, and coded-input parsing.
UpdateOrganization logo_url field
src/main/java/com/scalekit/grpc/scalekit/v1/organizations/UpdateOrganization.java, src/main/java/com/scalekit/grpc/scalekit/v1/organizations/UpdateOrganizationOrBuilder.java
UpdateOrganization message and OrBuilder add optional logo_url field (field 10) with presence tracking, accessors, and builder API integrated into serialization, size calculation, equality, hashing, and parsing logic.
Organizations domain Organization logo_url field
src/main/java/com/scalekit/grpc/scalekit/v1/organizations/Organization.java, src/main/java/com/scalekit/grpc/scalekit/v1/organizations/OrganizationOrBuilder.java
organizations/Organization message and OrBuilder add optional logo_url field (field 10) with field-number constant, message accessors, builder API, and full integration into serialization, size calculation, equality/hashing, and coded-input parsing.
Javadoc reference updates
src/main/java/com/scalekit/grpc/scalekit/v1/organizations/GeneratePortalLinkRequest.java, src/main/java/com/scalekit/grpc/scalekit/v1/organizations/GeneratePortalLinkRequestOrBuilder.java
Generated Javadoc line references for deprecated sso and directory_sync fields in GeneratePortalLinkRequest and its OrBuilder are updated to reflect proto source line changes. No functional method signatures or behavior changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • Avinash-Kamath

Poem

🐰 A logo_url field hops in,
Through auth and orgs it spreads its grin,
Generated code, a builder's delight,
Field number 8 and 10, getting it right!
Accessors bloom, serialization's tight,
CodeRabbit celebrates this proto-perfect sight! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 60.66% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the primary change: regenerating proto types with the addition of a logo_url field to Organization messages.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch b_d_org_logo

Comment @coderabbitai help to get the list of available commands and usage tips.

Tests for create with logoUrl, update to set/clear, and verification
that logoUrl is preserved after updateOrganizationSettings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant