Skip to content

Fix typos with codespell and bump backend dependencies#9693

Merged
fm3 merged 5 commits into
masterfrom
codespell-2026-06
Jun 22, 2026
Merged

Fix typos with codespell and bump backend dependencies#9693
fm3 merged 5 commits into
masterfrom
codespell-2026-06

Conversation

@fm3

@fm3 fm3 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Steps to test:

  • CI should be enough

  • Needs datastore update after deployment

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR performs spelling and typo corrections across the codebase: renames the JsonResultAttribues trait to JsonResultAttributes, renames SafeCachable to SafeCacheable, fixes the CLICK_TRESHOLD constant to CLICK_THRESHOLD, corrects various comment typos, standardizes hyphenation in the changelog, and bumps several backend dependency versions in project/Dependencies.scala.

Changes

Spelling Fixes and Dependency Updates

Layer / File(s) Summary
JsonResultAttributes and SafeCacheable trait renames
util/src/main/scala/com/scalableminds/util/mvc/ExtendedController.scala, app/models/task/TaskCreationResult.scala, webknossos-datastore/app/com/scalableminds/webknossos/datastore/dataformats/SafeCacheable.scala, webknossos-datastore/app/com/scalableminds/webknossos/datastore/storage/AgglomerateFileCache.scala, webknossos-datastore/app/com/scalableminds/webknossos/datastore/storage/Hdf5FileCache.scala
Renames public trait JsonResultAttribuesJsonResultAttributes in the definition and all usages; renames SafeCachableSafeCacheable in the trait definition and both cache classes that extend it.
CLICK_THRESHOLD constant rename
frontend/javascripts/viewer/view/right_border_tabs/abstract_tree_renderer.ts
Renames the misspelled CLICK_TRESHOLD constant to CLICK_THRESHOLD and updates its reference in getIdFromPos(); fixes a JSDoc parameter typo middelmiddle.
Backend dependency version bumps
project/Dependencies.scala
Updates Play SBT import syntax and bumps version constants for brotli, slick, aws, postgres, scala-logging, Google Cloud Storage, Blosc-Java, zstd JNI, and Woodstox.
Comment, changelog, and config text corrections
.codespellrc, CHANGELOG.released.md, app/security/CertificateValidationService.scala, conf/webknossos.versioned.routes, frontend/javascripts/admin/dataset/composition_wizard/03_select_datasets.tsx, frontend/javascripts/admin/user/permissions_and_teams_modal_view.tsx, frontend/javascripts/test/sagas/save_mutex_strategy_switching.spec.ts, frontend/javascripts/viewer/model/accessors/annotation_accessor.ts, frontend/javascripts/viewer/model/accessors/volumetracing_accessor.ts, frontend/javascripts/viewer/model/sagas/saving/save_saga.tsx, schema/evolutions/069-tasktype-project-unique-per-orga.sql, schema/evolutions/reversions/169-per-user-annotation-view-config.sql, webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeUpdateActions.scala
Fixes comment typos, standardizes "pre-selected"→"preselected" and "re-used"→"reused" in changelog, corrects "DatasStore"→"DataStore" in routes comment, and extends the codespell skip/ignore list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • MichaelBuessemeyer
  • normanrz

Poem

🐇 Hoppity-hop through the code I go,
Fixing each typo, high and low,
TRESHOLD becomes THRESHOLD with care,
AttribuesAttributes — now correct, I declare!
No more "pre-selected," just "preselected" today,
A tidy codebase is the bunny's hooray! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately captures the main purpose of the PR: fixing typos using codespell and bumping backend dependencies, which aligns with the comprehensive changeset.
Description check ✅ Passed The description is related to the changeset, providing testing instructions and noting deployment requirements, though it lacks detail about specific changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codespell-2026-06

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fm3 fm3 marked this pull request as ready for review June 15, 2026 14:59
@fm3 fm3 requested a review from MichaelBuessemeyer June 15, 2026 15:23

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. Thanks for the house keeping 🙏

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@project/Dependencies.scala`:
- Line 1: The import statement in Dependencies.scala uses the wildcard syntax
`*` which is only valid in Scala 3 and later. Since this project targets Scala
2.12, change the wildcard import syntax from `*` to `_` in the PlayImport import
statement. Replace the asterisk with an underscore to make the wildcard import
compatible with Scala 2.12 syntax.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 43324ae1-6f86-4853-8e16-3c652e8036a4

📥 Commits

Reviewing files that changed from the base of the PR and between 279e9a6 and dc13092.

📒 Files selected for processing (20)
  • .codespellrc
  • CHANGELOG.released.md
  • app/models/task/TaskCreationResult.scala
  • app/security/CertificateValidationService.scala
  • conf/webknossos.versioned.routes
  • frontend/javascripts/admin/dataset/composition_wizard/03_select_datasets.tsx
  • frontend/javascripts/admin/user/permissions_and_teams_modal_view.tsx
  • frontend/javascripts/test/sagas/save_mutex_strategy_switching.spec.ts
  • frontend/javascripts/viewer/model/accessors/annotation_accessor.ts
  • frontend/javascripts/viewer/model/accessors/volumetracing_accessor.ts
  • frontend/javascripts/viewer/model/sagas/saving/save_saga.tsx
  • frontend/javascripts/viewer/view/right_border_tabs/abstract_tree_renderer.ts
  • project/Dependencies.scala
  • schema/evolutions/069-tasktype-project-unique-per-orga.sql
  • schema/evolutions/reversions/169-per-user-annotation-view-config.sql
  • util/src/main/scala/com/scalableminds/util/mvc/ExtendedController.scala
  • webknossos-datastore/app/com/scalableminds/webknossos/datastore/dataformats/SafeCacheable.scala
  • webknossos-datastore/app/com/scalableminds/webknossos/datastore/storage/AgglomerateFileCache.scala
  • webknossos-datastore/app/com/scalableminds/webknossos/datastore/storage/Hdf5FileCache.scala
  • webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeUpdateActions.scala

Comment thread project/Dependencies.scala
@fm3 fm3 enabled auto-merge (squash) June 22, 2026 09:04
@fm3 fm3 merged commit 4e3f454 into master Jun 22, 2026
6 checks passed
@fm3 fm3 deleted the codespell-2026-06 branch June 22, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants