[WIP] Refactor rebasing code#9683
Draft
philippotto wants to merge 123 commits into
Draft
Conversation
…peteer-live-testing
…ollab mode setting
…ly at the same time
…knossos into puppeteer-live-testing
… annotation mutex
…knossos into puppeteer-live-testing
…knossos into puppeteer-live-testing
…knossos into puppeteer-live-testing
This method returns the mapped (agglomerate) id for a segment at a given position, respecting the active HDF5 mapping. It delegates to getDataValue for layers without local HDF5 mapping, and looks up ids in the local mapping for layers with local HDF5 mapping (proofread mode or editable mapping). Also extract fetchAgglomeratesForSegmentIds as a standalone async function to support this new method and reduce code duplication.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
philippotto
commented
Jun 12, 2026
| if (!success) { | ||
| return { successful: false, shouldTerminate: false }; | ||
| } | ||
| // todop: clarify with Michael. When reapplying own update actions, do we |
Member
Author
There was a problem hiding this comment.
allowAdditionalOperation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)
$PR_NUMBER.mdfile inunreleased_changesor use./tools/create-changelog-entry.py)