Scala3 Follow-Up #1: Fix Compiler Warnings#9682
Open
fm3 wants to merge 39 commits into
Open
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 176 files, which is 26 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (176)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks
MichaelBuessemeyer
approved these changes
Jun 16, 2026
MichaelBuessemeyer
left a comment
MichaelBuessemeyer
left a comment
Contributor
There was a problem hiding this comment.
Neat, thanks for the clean up.
Got 2 mini comments :D
Comment on lines
+5
to
+8
| import com.scalableminds.util.tools.Fox | ||
| import com.typesafe.scalalogging.LazyLogging | ||
| import models.user.User | ||
| import play.api.libs.json.{JsReadable, JsSuccess} |
Contributor
There was a problem hiding this comment.
why are these imports added. They seem unused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to test:
Issues: