fix(assistant): inline conversation history into the Claude prompt#18
Merged
Conversation
After PR #17 the PWA chat relied on `claude -p --session-id <conv-id>` to carry conversation context across turns. That broke for: 1) conversations that pre-dated the claude-cli backend (no on-disk Claude session existed for that UUID), 2) cases where two turns fired close together — Claude rejected the second with "Session ID is already in use", 3) proactive messages injected via /api/assistant/fire (Claude never saw them). Fix: always pull prior turns from our DB and inline them into the user prompt (last 30 turns, capped). Drop --session-id entirely so each spawn is a fresh session. Cheap, deterministic, surface-independent — any conversation, any backend, any restart, any proactive injection, Claude has full context. Verified: replied to a pre-cutover conversation with "what was my original question?" — Claude correctly recalled "List out my confirmed travel plans until August" and offered to answer it from notes/travel/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code