Skip to content

docs(checkbox): implement examples#433

Open
MarioCastigliano wants to merge 1 commit into
mainfrom
docs/checkbox-examples
Open

docs(checkbox): implement examples#433
MarioCastigliano wants to merge 1 commit into
mainfrom
docs/checkbox-examples

Conversation

@MarioCastigliano

Copy link
Copy Markdown
Contributor

Subtask of #358

@github-actions github-actions Bot added the pr: peer review required A peer review is required for this pull request label Jun 23, 2026

@jeripeierSBB jeripeierSBB left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the examples, please enhance with examples using Angular Forms (ngmodel, signal forms and reactive forms)

@@ -0,0 +1,39 @@
<form (submit)="submitHandler($event)">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should to use angular forms not a plain html form.
Please remember my message in our Teams Channel:

Whenever we have general controls we should probably stick to signal forms. For examples of our own form components (e.g. slider, checkbox, ...), we should provide, a ngModel, reactiveForms and signalForms example to demonstrate the functionality.

So this would mean to have three examples.

@MarioCastigliano MarioCastigliano force-pushed the docs/checkbox-examples branch from 0db0dda to 5b91f73 Compare June 25, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: peer review required A peer review is required for this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants