Skip to content

feat: improve multiple deletion process#1846

Open
Wizzzzzzard wants to merge 22 commits into
sassoftware:mainfrom
Wizzzzzzard:feat/improve-multiple-deletion-process
Open

feat: improve multiple deletion process#1846
Wizzzzzzard wants to merge 22 commits into
sassoftware:mainfrom
Wizzzzzzard:feat/improve-multiple-deletion-process

Conversation

@Wizzzzzzard

@Wizzzzzzard Wizzzzzzard commented Apr 2, 2026

Copy link
Copy Markdown
Member

Summary:
Implements a single confirmation dialog for multi-file deletion instead of prompting for each file individually. When users select multiple files or folders and choose to delete them via the context menu, they now see one confirmation dialog showing the total count of items to be deleted, rather than being prompted separately for each item.

  • Added new localized messages (DeleteMultipleWarningMessage, RecycleMultipleWarningMessage, RecycleMultipleDirtyWarning) in const.ts to support batch deletion confirmations
  • Refactored the deleteResource command in index.ts to collect all selected items and show a single confirmation based on the total count

Addresses #1290

Testing:
How did you test this change?

  1. Sign in with a valid Viya connection
  2. Open SAS Server or SAS Content in the explorer
  3. Select multiple files and/or folders (use Cmd/Ctrl+Click or Shift+Click)
  4. Right-click and select "Delete" from the context menu
  5. Verify that only ONE confirmation dialog appears showing the count of items (e.g., "Are you sure you want to permanently delete 5 items?" or "Are you sure you want to move 3 items to the Recycle Bin?")
  6. Test with a single file selection to ensure the original behavior is preserved (shows file name in confirmation)
  7. Test with folders containing unsaved files to verify the appropriate warning message appears

TODOs:

  • Add any supporting documentation and (optionally) update CHANGELOG.md

@Wizzzzzzard Wizzzzzzard force-pushed the feat/improve-multiple-deletion-process branch from be596a9 to ee40709 Compare April 2, 2026 11:34
@Wizzzzzzard

Copy link
Copy Markdown
Member Author

To test I created a folder and several files under tmp then selected them all and hit delete. That produces this dialogue:

image

Selecting delete confirmed to remove the files!

@Wizzzzzzard Wizzzzzzard marked this pull request as ready for review April 2, 2026 12:22
@Wizzzzzzard Wizzzzzzard self-assigned this Apr 2, 2026
@Wizzzzzzard

Copy link
Copy Markdown
Member Author

Also still works when deleting a single item:
image

Prompts again if trying to delete a file with unsaved changes:
image

@Wizzzzzzard

Copy link
Copy Markdown
Member Author

Deleting more than 10 files truncates the list as well:
image

image

@Wizzzzzzard Wizzzzzzard force-pushed the feat/improve-multiple-deletion-process branch from 7e60432 to 0fe077c Compare April 2, 2026 13:40
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
…n with count of files

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: c1c6cda
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 34ec547
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 18aa9fc

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
@Wizzzzzzard Wizzzzzzard force-pushed the feat/improve-multiple-deletion-process branch from 0fe077c to f5fd7d8 Compare April 6, 2026 10:07
…e saving it

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
…mediately deleting them

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
@allenfrazelle-vsce allenfrazelle-vsce added testing-complete Complete the pull requests testing and removed verification-needed labels Apr 14, 2026
@allenfrazelle-vsce

Copy link
Copy Markdown

Looks good, thanks Elijah!

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
@Wizzzzzzard Wizzzzzzard requested a review from 2TomLi April 14, 2026 18:07

@scottdover scottdover left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Wizzzzzzard. I haven't looked through all of this yet, but here are my general thoughts:

  • It was decided a while ago that we don't need a confirmation when moving files to a recycle bin. My assumption is that that still holds. With that in mind, I think we can remove the recycling bin notifications
  • For deletion, since the number of deletions is somewhat unbounded, I'd suggest keeping it simple and having two messages: One for single deletion, and one for multiple deletion. For multiple deletion, I'd stick to a message like "Are you sure you want to permanently delete {count} items?" without relying on spelling out every file. That'll hopefully cut down on some of the logic here
  • Last, for the dirty files issue, I'm wondering if a single message like this works for all cases: "The selected folders contain unsaved files, are you sure you want to delete?"

Comment thread client/src/components/ContentNavigator/ContentDataProvider.ts Outdated
Wizzzzzzard and others added 8 commits May 1, 2026 17:05
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

fix: ensuring consistent localization

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
@Wizzzzzzard

Copy link
Copy Markdown
Member Author

@scottdover I've actioned your feedback by removing the recycling notifications and simplifying the delete logic down, if you would be ok to re-review when you get the chance? :)

@Wizzzzzzard Wizzzzzzard requested a review from scottdover May 12, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing-complete Complete the pull requests testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants