feat: improve multiple deletion process#1846
Open
Wizzzzzzard wants to merge 22 commits into
Open
Conversation
be596a9 to
ee40709
Compare
Member
Author
Member
Author
Member
Author
7e60432 to
0fe077c
Compare
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
…n with count of files Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com> I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: c1c6cda I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 34ec547 I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 18aa9fc Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
0fe077c to
f5fd7d8
Compare
…to feat/improve-multiple-deletion-process
…zzzzzard/vscode-sas-extension into feat/improve-multiple-deletion-process
…e saving it Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
…mediately deleting them Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
|
Looks good, thanks Elijah! |
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
…to feat/improve-multiple-deletion-process
scottdover
reviewed
May 1, 2026
scottdover
left a comment
Contributor
There was a problem hiding this comment.
Hey @Wizzzzzzard. I haven't looked through all of this yet, but here are my general thoughts:
- It was decided a while ago that we don't need a confirmation when moving files to a recycle bin. My assumption is that that still holds. With that in mind, I think we can remove the recycling bin notifications
- For deletion, since the number of deletions is somewhat unbounded, I'd suggest keeping it simple and having two messages: One for single deletion, and one for multiple deletion. For multiple deletion, I'd stick to a message like "Are you sure you want to permanently delete {count} items?" without relying on spelling out every file. That'll hopefully cut down on some of the logic here
- Last, for the dirty files issue, I'm wondering if a single message like this works for all cases: "The selected folders contain unsaved files, are you sure you want to delete?"
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com> fix: ensuring consistent localization Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
…to feat/improve-multiple-deletion-process
Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>
Member
Author
|
@scottdover I've actioned your feedback by removing the recycling notifications and simplifying the delete logic down, if you would be ok to re-review when you get the chance? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary:
Implements a single confirmation dialog for multi-file deletion instead of prompting for each file individually. When users select multiple files or folders and choose to delete them via the context menu, they now see one confirmation dialog showing the total count of items to be deleted, rather than being prompted separately for each item.
DeleteMultipleWarningMessage,RecycleMultipleWarningMessage,RecycleMultipleDirtyWarning) inconst.tsto support batch deletion confirmationsdeleteResourcecommand inindex.tsto collect all selected items and show a single confirmation based on the total countAddresses #1290
Testing:
How did you test this change?
TODOs: