Skip to content

refactor: update vercel and migrate to vitest#68

Merged
sargant merged 8 commits into
mainfrom
modernization-2026
Mar 18, 2026
Merged

refactor: update vercel and migrate to vitest#68
sargant merged 8 commits into
mainfrom
modernization-2026

Conversation

@sargant

@sargant sargant commented Mar 18, 2026

Copy link
Copy Markdown
Owner

Updating and modernising some dependencies

…pendencies

- Changed the test command in package.json from "jest" to "vitest".
- Updated @vercel/node dependency version to 5.6.16.
- Updated typescript version to 5.9.3.
- Updated devDependencies: added vitest and updated @types/node, tsx, and vercel versions.
- Modified vite.config.ts to support Vitest configuration and adjusted the root directory based on the environment.
@vercel

vercel Bot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dfyb-run Ready Ready Preview, Comment Mar 18, 2026 9:03pm

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/sargant/dfyb.run/blob/f2f592724ef74f7f7faddf9ef7a9e249d2009ac8/package-lock.json#L19675-L19678
P1 Badge Regenerate the lockfile for Vitest's nested Vite deps

Adding Vitest 4 also adds a nested vite@8.0.0 here, but the lockfile never records that copy's optional esbuild/yaml packages. On npm 11.4.2, npm ci now aborts with Missing: esbuild@ from lock file and Missing: yaml@ from lock file, so any clean install on a current npm-based builder will fail before tests or builds can even start.


"vitest": "4.1.0"

P2 Badge Align the Vitest upgrade with the app's Vite major

vitest@4.1.0 peers on Vite 6+, but this repo still pins the application toolchain to vite 2.x. npm works around that by installing a second Vite copy under node_modules/vitest, so npm test will evaluate vite.config.ts with Vite 8 while vite build still uses Vite 2. Any test that touches the Vite plugin pipeline (React transform, assets, WindiCSS, etc.) is now exercising a different toolchain than production, which can hide real build regressions or introduce test-only failures.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sargant sargant changed the title refactor: update verbal and migrate to vitest refactor: update vercel and migrate to vitest Mar 18, 2026
- removed @types/jest version 27.0.3
- updated vite from version ^2.7.0 to version 7.3.1
fix: change output file extension from .js to .ts in encrypt-certs.ts

refactor: update tsconfig.json for module resolution and include paths

style: update gray color to neutral in windi.config.ts

feat: add TypeScript declaration file for WindiCSS in windicss-fix.d.ts
@sargant

sargant commented Mar 18, 2026

Copy link
Copy Markdown
Owner Author

@codex re-run the review

@sargant sargant merged commit e6ab093 into main Mar 18, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8eb3d4853d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/generate.ts Outdated
import { join } from 'path'

import * as certs from './certs.enc.js'
import * as certs from './certs.enc'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore a Node-resolvable import for certs.enc

Any non-bundled execution path for this API module (for example vercel dev or direct Node execution) now fails before the handler runs, because Node’s ESM resolver does not load ./certs.enc without an explicit extension. I verified that in this repo with node --experimental-transform-types, which raises ERR_MODULE_NOT_FOUND for this specifier. The new moduleResolution: "bundler" setting masks the problem during type-checking, so tsc can still pass while the runtime cannot import the certificates module.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant