Skip to content

ENH: allow specifying ransac at class inst of NoisyChannels#164

Merged
sappelhoff merged 3 commits into
mainfrom
ransac
Jul 17, 2025
Merged

ENH: allow specifying ransac at class inst of NoisyChannels#164
sappelhoff merged 3 commits into
mainfrom
ransac

Conversation

@sappelhoff

@sappelhoff sappelhoff commented Jul 17, 2025

Copy link
Copy Markdown
Owner

PR Description

This PR allows specifying ransac (True/False) not only when calling find_all_bads, but also at instantiation of the class NoisyChannels.

All changes here are fully backward compatible.

Merge Checklist

  • the PR has been reviewed and all comments are resolved
  • all CI checks pass
  • (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
  • (if applicable): the changes are documented in the changelog changelog.rst
  • (if applicable): new contributors have added themselves to the authors list in the CITATION.cff file

@codecov

codecov Bot commented Jul 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.61%. Comparing base (5fa005b) to head (03f83d2).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   98.60%   98.61%   +0.01%     
==========================================
  Files           7        7              
  Lines         715      721       +6     
==========================================
+ Hits          705      711       +6     
  Misses         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sappelhoff sappelhoff enabled auto-merge (squash) July 17, 2025 14:50
@sappelhoff sappelhoff merged commit d01afe0 into main Jul 17, 2025
10 checks passed
@sappelhoff sappelhoff deleted the ransac branch July 17, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant