fix: outdent indented numbered-list items (2 tutorials)#176
Open
jung-thomas wants to merge 1 commit into
Open
Conversation
Sibling numbered-list items 4. and 2. were indented further than their preceding siblings. CommonMark interprets that as a fresh nested <ol start=N>, which renders as a layout glitch on the new tutorial platform (sap-tutorials/tutorials-ims#168). Files changed (2 tutorials): - btp-sdm-gwi-onbrepo-jwt-token: outdent 4. (L57) from column 6 to column 4 to match siblings 1-3 (this is a nested list — child of the outer item 2., not flush-left) - luigi-app-react: outdent 2. (L356) from 2-space indent to flush-left to match sibling 1. Per-edit verification: each numbered marker is now flush with its matching sibling. CommonMark continuation content (code blocks, images) within each item retains its existing indent. Detected by: tutorials-ims/scripts/lint-tutorial-markdown.ts. Tracking: sap-tutorials/tutorials-ims#193.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Outdents 2 numbered-list items so they sit flush with their sibling markers instead of being interpreted by CommonMark as nested
<ol start="N">items. Detected bytutorials-ims/scripts/lint-tutorial-markdown.tsand tracked in tutorials-ims#193.Changes (2 tutorials)
btp-sdm-gwi-onbrepo-jwt-token4.from column 6 to column 4 to match siblings1./2./3.(this is a nested list — child of the outer2., NOT flush-left)luigi-app-react2.from 2-space indent to flush-left to match sibling1.Per-edit verification: each numbered marker is now flush with its matching sibling. CommonMark continuation content (code blocks, images) within each item retains its existing indent so it remains attached to the right list item.
Verification
Run
lint-tutorial-markdownagainst a fresh.tutorial-cache/after merge — these 2 tutorials should drop off the report.Related